Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-16318 - API changes to support state manager #1223

Closed

Conversation

conalsmith-r3
Copy link
Contributor

@conalsmith-r3 conalsmith-r3 commented Aug 20, 2023

The following design describes the state manager.

This set of changes facilitates these runtime-os changes. Most of these changes relate to https://r3-cev.atlassian.net/browse/CORE-16318.

  • State manager config will be presented to workers via boot config on the command line.
  • Defined a state-manager config schema that is polymorphic, if stateManagerType is DATABASE it holds database config. In future "REDIS" can provide its own config file.
  • Defined the state-manager database schema migration files. This sets up state table with some column types depending on the database being postgres or hsqldb.
  • A few other corda-api state manager related changes.

@conalsmith-r3 conalsmith-r3 force-pushed the conal/CORE-16318-stateManagerConfig branch 2 times, most recently from f8e26a1 to 64fccbc Compare August 21, 2023 16:17
@conalsmith-r3 conalsmith-r3 changed the base branch from release/os/5.1 to conal/CORE-15755-state-manager-parent August 21, 2023 16:26
@corda corda deleted a comment from corda-jenkins-ci02 bot Aug 21, 2023
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Aug 21, 2023

Jenkins build for PR 1223 build 19

Build Successful:
Jar artifact version produced by this PR: 5.1.0.888-alpha-1693845998564

@conalsmith-r3 conalsmith-r3 force-pushed the conal/CORE-16318-stateManagerConfig branch from 654ca36 to 13ef0cc Compare August 25, 2023 15:10
@conalsmith-r3 conalsmith-r3 changed the base branch from conal/CORE-15755-state-manager-parent to release/os/5.1 August 25, 2023 15:44
@jujoramos jujoramos requested a review from JamesHR3 August 31, 2023 09:06
@jujoramos jujoramos force-pushed the conal/CORE-16318-stateManagerConfig branch from c92a92a to d9aec2a Compare September 1, 2023 09:09
@jujoramos jujoramos force-pushed the conal/CORE-16318-stateManagerConfig branch from 0b3ecd0 to 62c1e75 Compare September 1, 2023 16:30
Copy link
Contributor Author

@conalsmith-r3 conalsmith-r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

<constraints nullable="false"/>
</column>
<column name="state" type="${state.column.type}">
<constraints nullable="false"/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May need to double check this, but when we complete a flow, we null the state, we'll have to now delete the key from state storage if we can't null the state (probably a better thing anyway)

@jujoramos
Copy link
Contributor

State manager configurations settings have been moved to #1240.

@github-actions github-actions bot deleted the conal/CORE-16318-stateManagerConfig branch December 21, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants