Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-16318: State Manager Configuration #1240

Merged
merged 8 commits into from
Sep 12, 2023
Merged

CORE-16318: State Manager Configuration #1240

merged 8 commits into from
Sep 12, 2023

Conversation

jujoramos
Copy link
Contributor

Add new polymorphic section under the current messaging configuration
section to hold state manager settings.

👮🏻👮🏻👮🏻 !!!! DESCRIBE YOUR CHANGES HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you run the unit, integration and smoke tests as described here?
  • If you added public APIs, did you write the JavaDocs?
  • If the changes are of interest to application developers, have you added them to the changelog (/docs/source/changelog.rst), and potentially the release notes (/docs/source/release-notes.rst)?
  • If you are contributing for the first time, please read the contributor agreement now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thanks for your code, it's appreciated! :)

@jujoramos
Copy link
Contributor Author

Changes split from #1223.

@jujoramos jujoramos mentioned this pull request Sep 7, 2023
Closed
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Sep 7, 2023 •
edited
Loading

Jenkins build for PR 1240 build 8

Build Successful:
Jar artifact version produced by this PR: 5.1.0.19-alpha-1694441708944

@jujoramos jujoramos mentioned this pull request Sep 7, 2023
Merged
conalsmith-r3
conalsmith-r3 previously approved these changes Sep 7, 2023
View reviewed changes
conalsmith-r3 and others added 5 commits September 8, 2023 16:25
@conalsmith-r3 @jujoramos
CORE-16318: State Manager Configuration
46392dd 
Add new polymorphic section under the current messaging configuration
section to hold state manager settings.
@jujoramos
Remove unncesary changes
b8ff137
@jujoramos
Add persistence unit name to configuration
70a6b46
@jujoramos
Review Feedback
6f69567
@jujoramos
Review Feedback
45b66ed
@jujoramos jujoramos mentioned this pull request Sep 11, 2023
Closed
@jujoramos jujoramos marked this pull request as ready for review September 11, 2023 13:21
@jujoramos jujoramos requested a review from a team as a code owner September 11, 2023 13:21
conalsmith-r3
conalsmith-r3 previously approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@conalsmith-r3 conalsmith-r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

driessamyn
driessamyn reviewed Sep 11, 2023
View reviewed changes
gradle.properties Outdated Show resolved Hide resolved
@conalsmith-r3 conalsmith-r3 merged commit 17bb735 into corda:release/os/5.1 Sep 12, 2023
@jujoramos jujoramos deleted the feature/CORE-16319 branch September 12, 2023 10:01
@conalsmith-r3 conalsmith-r3 mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conalsmith-r3 conalsmith-r3 conalsmith-r3 approved these changes

@JamesHR3 JamesHR3 JamesHR3 approved these changes

@driessamyn driessamyn Awaiting requested review from driessamyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jujoramos @driessamyn @JamesHR3 @conalsmith-r3