CORE-17386 - Create new topic for flow processor scheduled tasks. #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyriathar
reviewed
Sep 29, 2023
| @@ -269,5 +269,8 @@ private ScheduledTask() {} | |||
|
|
|||
| public static final String SCHEDULED_TASK_DB_PROCESSOR = "scheduled.task.db.processor"; | |||
| public static final String SCHEDULED_TASK_MAPPER_PROCESSOR = "scheduled.task.mapper.processor"; | |||
| public static final String SCHEDULED_TASK_TOPIC_FLOW_PROCESSOR = "scheduled.task.flow.processor"; | |||
There was a problem hiding this comment.
Suggested change
| public static final String SCHEDULED_TASK_TOPIC_FLOW_PROCESSOR = "scheduled.task.flow.processor"; | |
| public static final String SCHEDULED_TASK_FLOW_PROCESSOR_TOPIC = "scheduled.task.flow.processor"; |
I think we should do the same for the 2 above constants for consistency with rest of the cases (I missed that with SCHEDULED_TASK_DB_PROCESSOR).
There was a problem hiding this comment.
Sure. I can add it in this PR if you want?
driessamyn
force-pushed
the
driessamyn/CORE-17386/flow-worker-scheduled-task-topic
branch
from
da3256e to
86c2c1b
Compare
|
Jenkins build for PR 1271 build 5 Build Successful: |
JamesHR3
approved these changes
Sep 29, 2023
kyriathar
approved these changes
Sep 29, 2023
driessamyn
deleted the
driessamyn/CORE-17386/flow-worker-scheduled-task-topic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime-os PR: corda/corda-runtime-os#4740