Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-17386 - Add flow session timeout scheduled task #4740

Merged
merged 3 commits into from
Sep 29, 2023
Merged

CORE-17386 - Add flow session timeout scheduled task #4740

merged 3 commits into from
Sep 29, 2023

Conversation

driessamyn
Copy link
Contributor

API PR must be merged first: corda/corda-api#1271

@driessamyn driessamyn mentioned this pull request Sep 29, 2023
Merged
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Sep 29, 2023 •
edited
Loading

Jenkins build for PR 4740 build 3

Build Successful:
Jar artifact version produced by this PR: 5.1.0.0-alpha-1695992479769
Helm chart version produced by this PR: 5.1.0-alpha.1695992479769
Helm chart pushed to: oci://corda-os-docker-dev.software.r3.com/helm-charts/pr-4740/corda

@driessamyn driessamyn marked this pull request as ready for review September 29, 2023 10:56
@driessamyn driessamyn requested a review from a team as a code owner September 29, 2023 10:56
@driessamyn driessamyn requested a review from JamesHR3 September 29, 2023 10:56
JamesHR3
JamesHR3 previously approved these changes Sep 29, 2023
View reviewed changes
jujoramos
jujoramos previously approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@jujoramos jujoramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driessamyn driessamyn dismissed stale reviews from jujoramos and JamesHR3 via 0b367dc September 29, 2023 12:11
@vkolomeyko vkolomeyko changed the title CORE-17386 - Add flow session timout scheduled task CORE-17386 - Add flow session timeout scheduled task Sep 29, 2023
kyriathar
kyriathar reviewed Sep 29, 2023
View reviewed changes
Copy link
Contributor

@kyriathar kyriathar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we pls apply ScheduledTask.SCHEDULED_TASK_NAME_DB_PROCESSOR to DeduplicationTableCleanUpProcessor as well

mbrkic-r3
mbrkic-r3 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@mbrkic-r3 mbrkic-r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driessamyn driessamyn merged commit ac5a90a into release/os/5.1 Sep 29, 2023
1 check passed
@driessamyn driessamyn deleted the driessamyn/CORE-17386/session-timeout-scheduled-task branch September 29, 2023 14:28
@corda-jenkins-ci02 corda-jenkins-ci02 bot mentioned this pull request Oct 3, 2023
Merged
@corda-jenkins-ci02 corda-jenkins-ci02 bot mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrkic-r3 mbrkic-r3 mbrkic-r3 approved these changes

@kyriathar kyriathar kyriathar approved these changes

@JamesHR3 JamesHR3 JamesHR3 left review comments

@jujoramos jujoramos jujoramos left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@driessamyn @jujoramos @kyriathar @JamesHR3 @mbrkic-r3