CORE-15267 Add @CordaSerializable to MemberContext and MGMContext
#1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Scanning for breaking API changes introduced by this PR Scan Succeeded |
|
Jenkins build for PR 1341 build 4 Build Successful: |
|
Kudos, SonarCloud Quality Gate passed!
|
JamesHR3
approved these changes
Nov 17, 2023
| @@ -9,7 +9,7 @@ cordaProductVersion = 5.1.0 | |||
| # NOTE: update this each time this module contains a breaking change | |||
| ## NOTE: currently this is a top level revision, so all API versions will line up, but this could be moved to | |||
| ## a per module property in which case module versions can change independently. | |||
| cordaApiRevision = 38 | |||
There was a problem hiding this comment.
You might not need the API bump.
charlieR3
approved these changes
Nov 17, 2023
YashNabar
requested review from
driessamyn,
jasonbyrner3,
dimosr,
ronanbrowne,
rick-r3,
simon-johnson-r3,
blsemo,
Omar-awad,
aditisdesai,
vinir3,
vkolomeyko,
thiagoviana and
Sakpal
as code owners
dimosr
approved these changes
Nov 17, 2023
This was referenced Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marks
MemberContextandMGMContextinterfaces as@CordaSerializableto makeMemberInfoserializable. The corresponding runtime-os change registers custom serializers for its implementation types - corda/corda-runtime-os#5127