-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORE-15267 Make MemberInfo serializable #5127
Conversation
Jenkins build for PR 5127 build 2 Build Successful: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add some unit tests for these serializers? You might need to declare a test dependency on the AMQP serialization library to do so. There may be some issues around sandboxing that make this difficult/impossible, but worth investigating.
Discussed offline, end-to-end tests and any possible unit tests to be added in a follow-up PR (cc @dimosr @JamesHR3) |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Adds unit testing around custom AMQP serializers added for `MemberContext` and `MGMContext` as part of #5127. Also includes some refactoring around `MemberInfo` test utilities.
Makes
MemberInfo
serializable by registering custom serializers forMemberContext
andMGMContext
. The corresponding corda-api change marks these interfaces as@CordaSerializable
- corda/corda-api#1341This change was tested manually using a modified version of the combined worker smoke tests, by including
MemberInfo
in one of the flow states used by the tests. [build]It was also manually confirmed that this change does not break ABI compatibility, by running a modified version of the end-to-end flow tests against a combined worker compiled with the newer corda-api version.