Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-15267 Make MemberInfo serializable #5127

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Conversation

YashNabar
Copy link
Contributor

@YashNabar YashNabar commented Nov 17, 2023

Makes MemberInfo serializable by registering custom serializers for MemberContext and MGMContext. The corresponding corda-api change marks these interfaces as @CordaSerializable - corda/corda-api#1341

This change was tested manually using a modified version of the combined worker smoke tests, by including MemberInfo in one of the flow states used by the tests. [build]
It was also manually confirmed that this change does not break ABI compatibility, by running a modified version of the end-to-end flow tests against a combined worker compiled with the newer corda-api version.

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 17, 2023

Jenkins build for PR 5127 build 2

Build Successful:
Jar artifact version produced by this PR: 5.1.0.0-alpha-1700224233734
Helm chart version produced by this PR: 5.1.0-alpha.1700224233734
Helm chart pushed to: oci://corda-os-docker-dev.software.r3.com/helm-charts/pr-5127/corda

@dimosr dimosr requested a review from a team November 17, 2023 11:22
Copy link
Collaborator

@JamesHR3 JamesHR3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add some unit tests for these serializers? You might need to declare a test dependency on the AMQP serialization library to do so. There may be some issues around sandboxing that make this difficult/impossible, but worth investigating.

@YashNabar
Copy link
Contributor Author

Is it possible to add some unit tests for these serializers? You might need to declare a test dependency on the AMQP serialization library to do so. There may be some issues around sandboxing that make this difficult/impossible, but worth investigating.

Discussed offline, end-to-end tests and any possible unit tests to be added in a follow-up PR (cc @dimosr @JamesHR3)

charlieR3
charlieR3 previously approved these changes Nov 17, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@YashNabar YashNabar marked this pull request as ready for review November 17, 2023 13:26
@YashNabar YashNabar merged commit f441f27 into release/os/5.1 Nov 17, 2023
2 checks passed
@YashNabar YashNabar deleted the yash/CORE-15267 branch November 17, 2023 13:27
blsemo pushed a commit that referenced this pull request Nov 24, 2023
Adds unit testing around custom AMQP serializers added for `MemberContext` and `MGMContext` as part of #5127.
Also includes some refactoring around `MemberInfo` test utilities.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants