CORE-18961: Up flow sandbox cache size to 20 #1403
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Jenkins build for PR 1403 build 4 Build Successful: |
vkolomeyko
changed the title
|
Scanning for breaking API changes introduced by this PR Scan Succeeded |
|
| @@ -22,7 +22,7 @@ | |||
| "description": "The maximum number of cached flow sandboxes.", | |||
| "type": "integer", | |||
| "minimum": 0, | |||
| "default": 10 | |||
| "default": 20 | |||
There was a problem hiding this comment.
I think we need to be careful with this.
While I'm sure increasing this is a good idea (and maybe it should be much much higher (100+) in a production system, increasing this to get our tests to pass is masking a problem rather than fixing it.
The same issues will be hit at a higher load.
There was a problem hiding this comment.
Yes, I agree. The underlying problem is that we do not handle flow execution very well when sandbox cache eviction happens. This PR was just an attempt to improve the current situation with E2E tests.
An alternative could be to make E2E tests run less in parallel by using @Isolated or SAME_THREAD annotations.
|
Closing without merging. |
Having a current limit of 10 may too low to allow E2E tests to pass given that we have a number of vNodes running flows concurrently during E2E tests execution. With current limit of 10, sandbox context for the currently running flow may be closed, resulting bundle de-activation and
ClassNotFoundExceptionon the initiated flow execution.Tried with: corda/corda-runtime-os#5260
Proven to have a positive effect on E2E run: https://ci02.dev.r3.com/job/Corda5/job/corda5-e2e-tests/job/PR-369/13/