Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-18961: Up flow sandbox cache size to 20 #1403

Closed
wants to merge 4 commits into from
Closed

CORE-18961: Up flow sandbox cache size to 20 #1403

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca9d473
Up flow sandbox cache size to 20
vkolomeyko Dec 13, 2023
4b77488
Merge branch 'release/os/5.2' into vkolomeyko/e2e-flake-investigation
vkolomeyko Dec 14, 2023
dee52a8
Merge remote-tracking branch 'origin/release/os/5.2' into vkolomeyko/…
vkolomeyko Dec 15, 2023
0809314
Merge branch 'release/os/5.2' into vkolomeyko/e2e-flake-investigation
vkolomeyko Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...g-schema/src/main/resources/net/corda/schema/configuration/sandbox/1.0/corda.sandbox.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"description": "The maximum number of cached flow sandboxes.",
"type": "integer",
"minimum": 0,
"default": 10
"default": 20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to be careful with this.
While I'm sure increasing this is a good idea (and maybe it should be much much higher (100+) in a production system, increasing this to get our tests to pass is masking a problem rather than fixing it.
The same issues will be hit at a higher load.

CC @simon-johnson-r3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree. The underlying problem is that we do not handle flow execution very well when sandbox cache eviction happens. This PR was just an attempt to improve the current situation with E2E tests.
An alternative could be to make E2E tests run less in parallel by using @Isolated or SAME_THREAD annotations.

}
}
}
Expand Down