Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-17816 signatory signatures verification for contract verifying implementation #1421

Conversation

jennyang-r3
Copy link
Contributor

Exposed verifySignatorySignatures() to public in order to use in verifying notary server

@jennyang-r3 jennyang-r3 changed the title CORE-17816 expose verifySignatorySignatures CORE-17816 signatory signatures verification for contract verifying implementation Dec 19, 2023
@corda-jenkins-ci02
Copy link
Contributor

Scanning for breaking API changes introduced by this PR

Scan Succeeded

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Dec 19, 2023

Jenkins build for PR 1421 build 7

Build Successful:
Jar artifact version produced by this PR: 5.2.0.22-alpha-1703164133606

@jennyang-r3 jennyang-r3 marked this pull request as ready for review December 20, 2023 09:05
@jennyang-r3 jennyang-r3 requested a review from a team as a code owner December 20, 2023 09:05
@jennyang-r3 jennyang-r3 force-pushed the jennyang/CORE-17816-verifying-notary-sig-verification branch 2 times, most recently from 7bcd1b5 to 3808de3 Compare December 20, 2023 10:27
blsemo
blsemo previously approved these changes Dec 20, 2023
Copy link
Contributor

@blsemo blsemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jennyang-r3 jennyang-r3 force-pushed the jennyang/CORE-17816-verifying-notary-sig-verification branch from bb95da5 to 93748f4 Compare December 20, 2023 19:43
@jennyang-r3 jennyang-r3 force-pushed the jennyang/CORE-17816-verifying-notary-sig-verification branch from 93748f4 to 35fbb95 Compare December 21, 2023 13:08
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jennyang-r3 jennyang-r3 merged commit 8310e5b into release/os/5.2 Dec 21, 2023
@jennyang-r3 jennyang-r3 deleted the jennyang/CORE-17816-verifying-notary-sig-verification branch December 21, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants