Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-20522 Improve reconciler #1659

Closed

Conversation

williamvigorr3
Copy link
Contributor

No description provided.

@corda-jenkins-ci02
Copy link
Contributor

Scanning for breaking API changes introduced by this PR

Scan Succeeded

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Jun 12, 2024

Jenkins build for PR 1659 build 3

Build Successful:
Jar artifact version produced by this PR: 5.2.1.53-alpha-1719496161526

@corda-jenkins-ci02
Copy link
Contributor

Jenkins build for PR 1659 build 1

Build Successful:
Jar artifact version produced by this PR: 5.2.1.53-alpha-1718195295342

@@ -0,0 +1,20 @@
{
"type": "record",
"name": "LookUpKeyById",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we already have this type under name ByIdsRpcQuery? Do we need to introduce this new type, or maybe the old one covers this case as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This includes the tenant. I can change it if you want to be more generic so we can add more operations latter.

Copy link

This PR is stale because it has been open 7 days with no activity. Remove the Stale label or add a comment - otherwise this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 25, 2024
Copy link

@github-actions github-actions bot removed the Stale label Jun 28, 2024
Copy link

github-actions bot commented Jul 5, 2024

This PR is stale because it has been open 7 days with no activity. Remove the Stale label or add a comment - otherwise this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 5, 2024
Copy link

This PR was closed because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this Jul 12, 2024
@github-actions github-actions bot deleted the WillV/CORE-20522-Improve-reconciler branch August 13, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants