Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-20522 Improve reconciler #1659

Closed
wants to merge 4 commits into from
Closed

CORE-20522 Improve reconciler #1659

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4933446
Add LookupKeyById command
williamvigorr3 Jun 11, 2024
67ed319
Improve avro schema
williamvigorr3 Jun 12, 2024
7b23421
Merge remote-tracking branch 'origin/release/os/5.2' into WillV/CORE-…
williamvigorr3 Jun 12, 2024
118e316
Respond to review comments
williamvigorr3 Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ...n/resources/avro/net/corda/data/crypto/wire/ops/reconciliation/request/LookupKeyById.avsc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"type": "record",
"name": "LookUpKeyById",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we already have this type under name ByIdsRpcQuery? Do we need to introduce this new type, or maybe the old one covers this case as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This includes the tenant. I can change it if you want to be more generic so we can add more operations latter.

"namespace": "net.corda.data.crypto.wire.ops.reconciliation.request",
"doc": "Request to lookup for keys by their key ids. The maximum number of items is 20",
"fields": [
{
"name": "keyIds",
"type": [
"net.corda.data.crypto.ShortHashes",
"net.corda.data.crypto.SecureHashes"
],
"doc": "List of key ids"
},
{
"name": "tenantId",
"type": "string"
}
]
}
12 changes: 12 additions & 0 deletions ...urces/avro/net/corda/data/crypto/wire/ops/reconciliation/response/LookupKeyByIdError.avsc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"type": "record",
"name": "LookupKeyByIdError",
"namespace": "net.corda.data.crypto.wire.ops.reconciliation.response",
"doc": "Error result when looking up a key by Id.",
"fields": [
{
"name": "errorMessage",
"type": "net.corda.data.ExceptionEnvelope"
}
]
}
16 changes: 16 additions & 0 deletions ...es/avro/net/corda/data/crypto/wire/ops/reconciliation/response/LookupKeyByIdResponse.avsc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"type": "record",
"name": "LookupKeyByIdResponse",
"namespace": "net.corda.data.crypto.wire.ops.reconciliation.response",
"doc": "Result of the Lookup key by ID operation",
"fields": [
{
"name": "response",
"type": [
"net.corda.data.crypto.wire.CryptoSigningKeys",
"net.corda.data.crypto.wire.ops.reconciliation.response.LookupKeyByIdError"
],
"doc": "Response's payload, depends on the requested operation"
}
]
}