Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-20721: Add avro definitions to support new Group RestResource #1666

Conversation

Tom-Fitzpatrick
Copy link
Contributor

@Tom-Fitzpatrick Tom-Fitzpatrick commented Jun 27, 2024

This adds new avro schemas to support the new RBAC Group Rest Resource being added in corda/corda-runtime-os#6233.

@Tom-Fitzpatrick Tom-Fitzpatrick force-pushed the tomf/CORE-20721/add-avro-resources-for-rbac-group branch from 62125ac to 5148598 Compare June 27, 2024 16:22
@corda-jenkins-ci02
Copy link
Contributor

Scanning for breaking API changes introduced by this PR

Scan Succeeded

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Jun 27, 2024

Jenkins build for PR 1666 build 4

Build Successful:
Jar artifact version produced by this PR: 5.3.0.14-alpha-1719590853990

@Tom-Fitzpatrick Tom-Fitzpatrick marked this pull request as ready for review June 28, 2024 13:13
@Tom-Fitzpatrick Tom-Fitzpatrick requested a review from a team June 28, 2024 13:13
@vkolomeyko vkolomeyko requested a review from a team June 28, 2024 13:26
vkolomeyko
vkolomeyko previously approved these changes Jun 28, 2024
Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@vkolomeyko vkolomeyko self-requested a review June 28, 2024 17:15
Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tom-Fitzpatrick Tom-Fitzpatrick merged commit 527bb42 into release/os/5.3 Jul 1, 2024
4 checks passed
@Tom-Fitzpatrick Tom-Fitzpatrick deleted the tomf/CORE-20721/add-avro-resources-for-rbac-group branch July 1, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants