CORE-20721: Add RBAC Group rest resource #6233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
…group Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Tom-Fitzpatrick
force-pushed
the
tomf/CORE-20721/add-rbac-group-rest-resource
branch
from
e2441b7 to
5c38681
Compare
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Tom-Fitzpatrick
commented
Jun 28, 2024
gradle.properties
Outdated
| @@ -39,7 +39,7 @@ commonsLangVersion = 3.12.0 | |||
| commonsTextVersion = 1.10.0 | |||
| # Corda API libs revision (change in 4th digit indicates a breaking change) | |||
| # Change to 5.3.0.xx-SNAPSHOT to pick up maven local published copy | |||
| cordaApiVersion=5.3.0.14-beta+ | |||
| cordaApiVersion=5.3.0.14-alpha-1719505397377 | |||
There was a problem hiding this comment.
I will revert this once corda/corda-api#1666 has been merged
|
Jenkins build for PR 6233 build 17 Build Successful: |
Signed-off-by: TomFitzpatrick <[email protected]>
vkolomeyko
reviewed
Jun 28, 2024
...sion-endpoint/src/main/kotlin/net/corda/libs/permissions/endpoints/v1/group/GroupEndpoint.kt
Outdated
Show resolved
Hide resolved
...sion-endpoint/src/main/kotlin/net/corda/libs/permissions/endpoints/v1/group/GroupEndpoint.kt
Show resolved
Hide resolved
.../main/kotlin/net/corda/libs/permissions/endpoints/v1/group/types/GroupContentResponseType.kt
Outdated
Show resolved
Hide resolved
.../main/kotlin/net/corda/libs/permissions/endpoints/v1/group/types/GroupContentResponseType.kt
Outdated
Show resolved
Hide resolved
...nager/src/main/kotlin/net/corda/libs/permissions/manager/response/GroupContentResponseDto.kt
Outdated
Show resolved
Hide resolved
BenYip123
reviewed
Jun 28, 2024
...pl/src/test/kotlin/net/corda/libs/permissions/manager/impl/PermissionGroupManagerImplTest.kt
Outdated
Show resolved
Hide resolved
...-manager/src/main/kotlin/net/corda/libs/permissions/manager/request/DeleteGroupRequestDto.kt
Show resolved
Hide resolved
…line Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
vkolomeyko
reviewed
Jul 1, 2024
...sion-endpoint/src/main/kotlin/net/corda/libs/permissions/endpoints/v1/group/GroupEndpoint.kt
Outdated
Show resolved
Hide resolved
… empty. Co-authored-by: Viktor Kolomeyko <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
Signed-off-by: TomFitzpatrick <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates the GroupRestResource to allow creation and management of RBAC Groups. It includes all changes to support the Rest worker side of the work, up until sending the PermissionManagementRequest on Kafka. The DB side of this work will be continued in a following PR as this one is getting quite long.
This is supported by api changes in #6231.