Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Go version to 1.22 in go.mod and workflows #29

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

CharlieTLe
Copy link
Member

I updated go.mod to use 1.22 and ran the following to get these changes:

go mod tidy
go mod vendor

There are still other parts of the repo that are using an older version of Go (like in the Dockerfiles), but I'll update those in a different PR since this change is already kind of large.

@CharlieTLe CharlieTLe added the enhancement New feature or request label Apr 21, 2024
@CharlieTLe CharlieTLe requested a review from friedrichg April 21, 2024 00:27
@CharlieTLe CharlieTLe self-assigned this Apr 21, 2024
I updated `go.mod` to use 1.22 and ran the following to get these
changes:

```sh
go mod tidy
go mod vendor
```

There are still other parts of the repo that are using an older version
of Go (like in the Dockerfiles), but I'll update those in a different PR
since this change is already kind of large.

Signed-off-by: Charlie Le <[email protected]>
Following instructions from https://github.com/golangci/golangci-lint-action

Signed-off-by: Charlie Le <[email protected]>
Signed-off-by: Charlie Le <[email protected]>
Copy link
Member

@friedrichg friedrichg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

you can do the changelog thing in the other PR

@friedrichg friedrichg merged commit aeb2fb4 into cortexproject:main Apr 23, 2024
4 checks passed
friedrichg pushed a commit that referenced this pull request May 9, 2024
* Upgrade Go version to 1.22 in go.mod and workflows

I updated `go.mod` to use 1.22 and ran the following to get these
changes:

```sh
go mod tidy
go mod vendor
```

There are still other parts of the repo that are using an older version
of Go (like in the Dockerfiles), but I'll update those in a different PR
since this change is already kind of large.

Signed-off-by: Charlie Le <[email protected]>

* Update usage golangci

Following instructions from https://github.com/golangci/golangci-lint-action

Signed-off-by: Charlie Le <[email protected]>

* Deprecate use of ioutil package

Signed-off-by: Charlie Le <[email protected]>

* Remove unused parameters

Signed-off-by: Charlie Le <[email protected]>

---------

Signed-off-by: Charlie Le <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants