Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: globe metrics that update every minute [UA-8598] #11

Merged
merged 13 commits into from
Mar 8, 2024

Conversation

shidanjavaheri
Copy link
Contributor

@shidanjavaheri shidanjavaheri commented Mar 6, 2024

UA-8598 🚀

Proposed changes:

  • Fix debugging message for when environment is set 🐛
    • query.env was undefined in the production environment, ie. the url did not end with ?env=prd, even though it does in a local deploy. This may be due to some known netlify issues with redirection
    • Fixed by setting the environment to prd by default if the query param was undefined, and clarifying debugging logs
    • Even with no query param ?env=prd at the end of the url, the default environment is now prd
  • Removed extra check for an undefined environment in the useEffect that calls the getMetrics() method once per minute.
    • getMetrics() already performs this check and reverts to a default value

How to test

  • Deployed locally ✅
  • Deploy Preview works as expected ✅

Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for magical-pithivier-d4d6c1 ready!

Name Link
🔨 Latest commit da48a87
🔍 Latest deploy log https://app.netlify.com/sites/magical-pithivier-d4d6c1/deploys/65ea1ef56f1e8000080c65c9
😎 Deploy Preview https://deploy-preview-11--magical-pithivier-d4d6c1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shidanjavaheri shidanjavaheri marked this pull request as ready for review March 7, 2024 20:47
@mpayne-coveo mpayne-coveo merged commit 259ea45 into main Mar 8, 2024
6 checks passed
@mpayne-coveo mpayne-coveo deleted the fix/UA-8598_globe_values_update_every_minute branch March 8, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants