-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: globe metrics that update every minute [UA-8598] #11
Merged
mpayne-coveo
merged 13 commits into
main
from
fix/UA-8598_globe_values_update_every_minute
Mar 8, 2024
Merged
fix: globe metrics that update every minute [UA-8598] #11
mpayne-coveo
merged 13 commits into
main
from
fix/UA-8598_globe_values_update_every_minute
Mar 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for magical-pithivier-d4d6c1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mpayne-coveo
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UA-8598 🚀
Proposed changes:
?env=prd
, even though it does in a local deploy. This may be due to some known netlify issues with redirectionprd
by default if the query param was undefined, and clarifying debugging logs?env=prd
at the end of the url, the default environment is nowprd
getMetrics()
method once per minute.getMetrics()
already performs this check and reverts to a default valueHow to test