Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: globe metrics that update every minute [UA-8598] #11

Merged
merged 13 commits into from
Mar 8, 2024
Merged

fix: globe metrics that update every minute [UA-8598] #11

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
77f6d4e
fix: globe metrics that update every minute [UA-8598]
shidanjavaheri Mar 4, 2024
30170b3
fix: undo additional check on the variable env [UA-8598]
shidanjavaheri Mar 7, 2024
85468b6
fix: add check to set query param in url by default [UA-8598]
shidanjavaheri Mar 7, 2024
aaa3c0b
fix: cover more cases with default environment value [UA-8598]
shidanjavaheri Mar 7, 2024
0e29f1f
fix: use setQuery function to update env query param [UA-8598]
shidanjavaheri Mar 7, 2024
0e76c1a
fix: remove unnecessary check on undefined env variable [UA-8598]
shidanjavaheri Mar 7, 2024
6d479e4
fix: add redirect rule for default environment [UA-8598]
shidanjavaheri Mar 7, 2024
1dc9aad
fix: force redirection [UA-8598]
shidanjavaheri Mar 7, 2024
b5a2e49
fix: add debugging message to query value in globeandpanel.tsx [UA-8598]
shidanjavaheri Mar 7, 2024
4658c97
fix: futher debugging message for query.env [UA-8598]
shidanjavaheri Mar 7, 2024
385ef15
fix: remove changes that didn't work [UA-8598]
shidanjavaheri Mar 7, 2024
7d9d2d1
fix: trailing whitespace [UA-8598]
shidanjavaheri Mar 7, 2024
da48a87
fix: check to set default env value [UA-8598]
shidanjavaheri Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions src/Charts.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,13 @@ export const Charts: FunctionComponent<ChartsProps> = (props) => {
);

useEffect(() => {
if (query.env !== env) {
console.log("environment is now: ", env)
if (query.env !== env && query.env) {
console.log("environment is now: ", query.env)
setEnv(query.env!);
}
} else if (query.env !== env){
console.log("environment set to default: prd")
setEnv("prd");
}
}, [query.env, env])

useEffect(() => {
Expand Down Expand Up @@ -265,15 +268,13 @@ export const Charts: FunctionComponent<ChartsProps> = (props) => {
}, [animationTick]);

useEffect(() => {
if (env !== undefined) {
getMetrics()
const timeout = setInterval(async () => {
getMetrics()
const timeout = setInterval(async () => {
getMetrics()
}, 60000);
return () => {
clearInterval(timeout);
};
}
}, 60000);
return () => {
clearInterval(timeout);
};
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [env]);

Expand Down
Loading