Timestamp values: Remove the use of "naive" Python datetime objects
#667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
remove-utcfromtimestamp
branch
from
dda9da9 to
c7055bf
Compare
Python: Remove invocations to deprecated `datetime.utcfromtimestamp()`. This is a possible BREAKING CHANGE about returned Python ``datetime`` objects: > Removed the use of "naive" Python ``datetime`` objects, i.e. instances without ``tzinfo`` attribute set. When no ``time_zone`` information is specified when creating a database connection or cursor, ``datetime`` objects will now use Coordinated Universal Time (UTC), like CrateDB is storing timestamp values in this format. This update is coming from a deprecation of Python's ``datetime.utcfromtimestamp()``, which is effectively also phasing out the use of "naive" timestamp objects in Python, in favor of using timezone-aware objects, also to represent datetimes in UTC. It may be a breaking change for some users of the library that don't expect to receive "aware" ``datetime`` objects from now on. DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC).
amotl
force-pushed
the
remove-utcfromtimestamp
branch
from
c7055bf to
13da63b
Compare
kneth
approved these changes
Nov 4, 2024
| """ | ||
| https://docs.python.org/3/library/datetime.html | ||
| """ | ||
| if value is None: | ||
| return None | ||
| return datetime.utcfromtimestamp(value / 1e3) | ||
| return dt.datetime.fromtimestamp(value / 1e3, tz=dt.timezone.utc) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Python: Remove invocations to deprecated
datetime.utcfromtimestamp().World: Make datetime handling like it's 2024.
Summary
This is a possible BREAKING CHANGE about returned Python
datetimeobjects:Details
When no
time_zoneinformation is specified when creating a database connection or cursor,datetimeobjects will now use Coordinated Universal Time (UTC), like CrateDB is storing timestamp values in this format.This update is coming from a deprecation of Python's
datetime.utcfromtimestamp(), which is effectively also phasing out the use of "naive" timestamp objects in Python, in favor of using timezone-aware objects, also to represent datetimes in UTC. It may be a breaking change for some users of the library that don't expect to receive "aware"datetimeobjects from now on.