Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Demonstrate Python test layer implementations #280

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Feb 8, 2024

About

Only "Testcontainers for Java" is being presented up until now. This patch intends to level up on the Python side of things.

What's inside

The patch demonstrates the whole matrix of building test harnesses with Python, using both unittest and pytest, with and without "Testcontainers for Python".

  • When using Testcontainers, it relies on the corresponding test layer provided by cratedb-toolkit.
  • When not using Testcontainers, it relies on the test layers provided by pytest-crate and cr8.

See also the corresponding README files.

Notes about CI

Outlook

/cc @pilosus, @karynzv, @marijaselakovic, @hlcianfagna, @hammerhead, @proddata, @SStorm, @surister

@amotl amotl force-pushed the amo/testing-python branch 4 times, most recently from ff9ff30 to cd3e3df Compare February 10, 2024 01:17
@amotl amotl force-pushed the amo/testing-python branch from cd3e3df to a4d4104 Compare February 10, 2024 13:47
@amotl amotl changed the title Testing: Demonstrate test utilities with Python Testing: Demonstrate Python test layer implementations Feb 10, 2024
@amotl amotl force-pushed the amo/testing-python branch from a4d4104 to 488cd6d Compare February 10, 2024 17:23
@amotl amotl requested review from seut and matriv February 10, 2024 17:28
@amotl amotl marked this pull request as ready for review February 10, 2024 17:28
@amotl amotl requested a review from surister February 10, 2024 17:29
The patch demonstrates the whole matrix of building test harnesses with
Python, using both unittest and pytest, with and without "Testcontainers
for Python".

It only exercises basic features of the corresponding test adapters.
Demonstrating advanced features like test layer parameterization can be
added on behalf of subsequent iterations.
@SStorm
Copy link

SStorm commented Feb 12, 2024

That's nice, but is it worth mentioning https://pypi.org/project/pytest-crate/ (shout out to @chaudum). We use it for all our testing.

Ignore me I did not see that you are already using it 🙈

@amotl amotl merged commit 2fa4476 into main Feb 12, 2024
7 checks passed
@amotl amotl deleted the amo/testing-python branch February 12, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants