Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(deps): update github action upload-artifact to v4 #1098

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Dec 14, 2023

This PR updates the usage of actions/upload-artifact from v3 to actions/upload-artifact@v4 in affected workflows:

The v3 version actions/[email protected] was tied to the deprecated Node.js 16 version which entered end-of-life on Sep 9, 2023. The initial v4 version actions/[email protected] has been migrated to use Node.js 20, which currently holds LTS (Long Term Support) status.

Migrating the usage of actions/upload-artifact in the Cypress GitHub Action examples from v3 to v4 avoids deprecation warnings which would otherwise appear if the workflows continued to depend on Node.js 16.

Verification

Examine the workflow run logs and ensure that the expected files are captured and uploaded:

References

@cypress-app-bot
Copy link

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeMcC399 Thorough as always. Thank you!

@jennifer-shehane jennifer-shehane merged commit 4ef4686 into cypress-io:master Dec 18, 2023
71 checks passed
@MikeMcC399 MikeMcC399 deleted the update/artifacts-v4 branch December 18, 2023 18:35
Copy link

🎉 This PR is included in version 6.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants