Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(deps): update github action upload-artifact to v4 #1098

Merged
merged 2 commits into from
Dec 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/example-chrome.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
# As of Cypress v8.0 the `cypress run` command
# executes tests in `headless` mode by default

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: screenshots-headless-chrome
path: examples/browser/cypress/screenshots
Expand All @@ -50,7 +50,7 @@ jobs:
headed: true
summary-title: 'Chrome headed'

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: screenshots-headed-chrome
path: examples/browser/cypress/screenshots
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/example-firefox.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
browser: firefox

# report screenshot size and store the screenshots as test artifacts
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: screenshots-in-firefox
path: examples/browser/cypress/screenshots
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ jobs:

### Project ID and Record Key

To record the project needs `projectId` and `recordKey`.
To record the project needs `projectId` and `recordKey`.

Typically, the `projectId` is stored in the [Cypress Configuration File](https://docs.cypress.io/guides/references/configuration#Configuration-File), while the `recordKey` is set as a [CLI parameter](https://docs.cypress.io/guides/guides/command-line#cypress-run-record-key-lt-record-key-gt). If you want to avoid this, both the `projectId` and `recordKey` can be provided as environment variables using [GitHub secrets](https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions).

Expand Down Expand Up @@ -424,7 +424,7 @@ jobs:

Please refer to the [Cypress Cloud Git information environment variables](https://on.cypress.io/guides/continuous-integration/introduction#Git-information) section in our documentation for more examples.

Please refer to the [default GitHub environment variables](https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables) for additional GitHub examples.
Please refer to the [default GitHub environment variables](https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables) for additional GitHub examples.

### Automatic PR number and URL detection

Expand Down Expand Up @@ -582,14 +582,14 @@ jobs:
- uses: actions/checkout@v4
- uses: cypress-io/github-action@v6
# after the test run completes store videos and any screenshots
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
# add the line below to store screenshots only on failures
# if: failure()
with:
name: cypress-screenshots
path: cypress/screenshots
if-no-files-found: ignore # 'warn' or 'error' are also available, defaults to `warn`
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: cypress-videos
path: cypress/videos
Expand Down