Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicative all-at-once concatenate with join operations #168

Merged
merged 1 commit into from
Mar 16, 2024
Merged

Remove duplicative all-at-once concatenate with join operations #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions cytotable/convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
CytoTable: convert - transforming data for use with pyctyominer.
"""


import itertools
import logging
import uuid
Expand Down Expand Up @@ -841,19 +840,6 @@ def _concat_join_sources(
if pathlib.Path(dest_path).is_dir():
shutil.rmtree(path=dest_path)

# write the concatted result as a parquet file
_write_parquet_table_with_metadata(
table=pa.concat_tables(
tables=[
parquet.read_table(
table_path, memory_map=CYTOTABLE_ARROW_USE_MEMORY_MAPPING
)
for table_path in join_sources
]
),
where=dest_path,
)

# build a parquet file writer which will be used to append files
# as a single concatted parquet file, referencing the first file's schema
# (all must be the same schema)
Expand Down
Loading