[wip] adding nwb viewer #849
Conversation
No URL from dandi would work for it just yet, bioimagesuiteweb/bisweb#127 but I hope the fix is soon to come and IMHO it should be just the asset download url (to API, which mints signed url with content disposition) which web ui already provide for download |
|
@yarikoptic - thanks for clarifying. I thought, that @waxlamp was able to see the image last week, but maybe it was something special about that image |
|
re bisweb - fix was implemented, and available in "alpha" deployment to try out on e.g. https://bioimagesuiteweb.github.io/alphaapp/viewer.html?image=https://api.dandiarchive.org/api/assets/5ab0247b-659a-4593-b251-b338676de725/download/ |
Co-authored-by: Daniel Chiquito <[email protected]>
|
@yarikoptic - your link works! but any idea why this is not working? just trying to make it works for this example |
|
@yarikoptic - wait, I think this might just work for edit |
|
I will need some help with testing this functionality |
| } | ||
| if (file_ext === 'nwb') { | ||
| return `http://nwbexplorer.opensourcebrain.org/nwbfile=${publishRest.assetDownloadURI(this.identifier, this.version, asset_id)}`; | ||
| } |
There was a problem hiding this comment.
I would prefer if code was separated from registry of services, so that registry could be reused later by multiple portals.
See https://github.com/datalad/datalad-deprecated/blob/master/datalad_deprecated/resources/website/assets/js/main.js#L21 and how used
There was a problem hiding this comment.
Note: we need to add maxsize field there and set it to eg 1GB or might be even less for bisweb. Sure to limitations extracted data must not exceed 4GB and anyways, download might be too slow etc. So I wouldn't bother exposing that service for known to fail out be problematic files
| if (file_ext === 'nwb') { | ||
| return `http://nwbexplorer.opensourcebrain.org/nwbfile=${publishRest.assetDownloadURI(this.identifier, this.version, asset_id)}`; | ||
| } | ||
|
|
There was a problem hiding this comment.
after bioimagesuiteweb/bisweb#129 is addressed, we should also add .tiff into this "registry" (also with similar limits on the file size). ATM bisweb falls into "it is a nifti" if there is no file extension (as our endpoints and blob files have none), but IMHO should work whenever content-disposition is respected (where we do provide the extension)
There was a problem hiding this comment.
Looks great, I think the button placement and icon selection is perfect.
Just for future reference, it's better to create a branch and work off of that for PRs then to fork the repo. Doing so enables Netlify deploy previews, which makes testing out changes easier.
Co-authored-by: Yaroslav Halchenko <[email protected]>
|
@mvandenburgh , @yarikoptic - thanks for your suggestions. Trying to figure out the code from datalad and wondering if we want to have a list of multiple services and multiple buttons to open the file? Or we want to provide just a default viewer for some extensions? edit |
btw @djarecka not sure if you are already aware, but the vuetify docs are really good and have a bunch of different examples with the corresponding Vue/Vuetify code for you to copy/paste and modify to your liking. Looks like this example is similar to what @yarikoptic was showing today https://vuetifyjs.com/en/components/menus/#use-in-components |
|
Thank you @mvandenburgh ! that's very helpful! |
…ion that gets all possible services; creating a contex menu for the services instead of button
Co-authored-by: Mike VanDenburgh <[email protected]>
|
@mvandenburgh - thanks for review, I will add one more thing that @dchiquito suggested and I will create a branch from this repo, to enable CI |
…e file is bigger than the maxsize, the service will not be added to the list and shown to the user
|
open #854 instead (created a new branch on upstream) |
@waxlamp , @mvandenburgh - please take a look if this is a good place and way to add this extra button.
This is still not finished, since I'm having problem with providing a correct url to the bioimagesuiteweb viewer.
@waxlamp - I remember it worked for you, but I'm having some issues now. Trying different URLs from the dandi info website, but each time the viewer gives me an error.
Could you please recreate a proper url for this file as an example.
closes #821