Skip to content
This repository has been archived by the owner on Jan 14, 2022. It is now read-only.

[wip] adding nwb viewer #849

Closed
wants to merge 9 commits into from
Closed

[wip] adding nwb viewer #849

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f41f523
adding viewURI that will redirect to bioimagesuiteweb viewer
djarecka Aug 20, 2021
905be7d
Update src/views/FileBrowserView/PublishFileBrowser.vue
djarecka Aug 20, 2021
6050a0c
adding fileExtension check and provide viewers for nwb files and nii
djarecka Aug 21, 2021
543ce34
Update src/views/FileBrowserView/PublishFileBrowser.vue
djarecka Aug 23, 2021
978a951
creating a list with external services for each extension and a funct…
djarecka Aug 24, 2021
9c617b8
resolving conflicts
djarecka Aug 24, 2021
d9a851c
Update src/views/FileBrowserView/PublishFileBrowser.vue
djarecka Aug 24, 2021
57097cc
adding services to the item object (avoiding multiple calls to getExt…
djarecka Aug 24, 2021
d5661cd
adding maxsize for each element of the EXTRERNAL_SERVICES list: if th…
djarecka Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions src/views/FileBrowserView/PublishFileBrowser.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,19 @@
</v-btn>
</v-list-item-action>

<v-list-item-action v-if="item.asset_id && fileExtension(item.name)">
<v-btn
icon
:href="viewURI(item.asset_id, item.name)"
target="_blank"
rel="noopener"
>
<v-icon color="primary">
mdi-file-eye
</v-icon>
</v-btn>
</v-list-item-action>

<v-list-item-action
v-if="item.size"
class="justify-end"
Expand Down Expand Up @@ -278,6 +291,31 @@ export default {
return publishRest.assetDownloadURI(this.identifier, this.version, asset_id);
},

viewURI(asset_id, name) {
const file_ext = this.fileExtension(name);
if (file_ext === 'nii') {
return `https://bioimagesuiteweb.github.io/alphaapp/viewer.html?image=${publishRest.assetDownloadURI(this.identifier, this.version, asset_id)}`;
djarecka marked this conversation as resolved.
Show resolved Hide resolved
}
if (file_ext === 'nwb') {
return `http://nwbexplorer.opensourcebrain.org/nwbfile=${publishRest.assetDownloadURI(this.identifier, this.version, asset_id)}`;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if code was separated from registry of services, so that registry could be reused later by multiple portals.
See https://github.com/datalad/datalad-deprecated/blob/master/datalad_deprecated/resources/website/assets/js/main.js#L21 and how used

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: we need to add maxsize field there and set it to eg 1GB or might be even less for bisweb. Sure to limitations extracted data must not exceed 4GB and anyways, download might be too slow etc. So I wouldn't bother exposing that service for known to fail out be problematic files


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after bioimagesuiteweb/bisweb#129 is addressed, we should also add .tiff into this "registry" (also with similar limits on the file size). ATM bisweb falls into "it is a nifti" if there is no file extension (as our endpoints and blob files have none), but IMHO should work whenever content-disposition is respected (where we do provide the extension)

return undefined;
},

fileExtension(name) {
let ext;
const name_split_ar = name.split('.');
if (name_split_ar[name_split_ar.length - 1] === 'nwb') {
ext = 'nwb';
} else if (name_split_ar[name_split_ar.length - 1] === 'nii' || name_split_ar[name_split_ar.length - 2] === 'nii') {
ext = 'nii';
} else {
ext = false;
djarecka marked this conversation as resolved.
Show resolved Hide resolved
}
return ext;
},

assetMetadataURI(asset_id) {
return publishRest.assetMetadataURI(this.identifier, this.version, asset_id);
},
Expand Down