Add translation strings for share button labels #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobArrow
force-pushed
the
KBHBIB-24-share-buttons-translations
branch
from
4846d19 to
ab19321
Compare
JacobArrow
force-pushed
the
KBHBIB-24-share-buttons-translations
branch
from
0cdcb15 to
428fdd0
Compare
JacobArrow
force-pushed
the
KBHBIB-24-share-buttons-translations
branch
from
428fdd0 to
d12461e
Compare
JacobArrow
force-pushed
the
KBHBIB-24-share-buttons-translations
branch
from
d12461e to
372a79c
Compare
JacobArrow
force-pushed
the
KBHBIB-24-share-buttons-translations
branch
from
372a79c to
78a91d1
Compare
JacobArrow
force-pushed
the
KBHBIB-24-share-buttons-translations
branch
from
78a91d1 to
1343d19
Compare
JacobArrow
force-pushed
the
KBHBIB-24-share-buttons-translations
branch
from
1343d19 to
da85a54
Compare
JacobArrow
force-pushed
the
KBHBIB-24-share-buttons-translations
branch
from
da85a54 to
55a4dc4
Compare
Adamik10
requested changes
Dec 13, 2024
web/modules/custom/dpl_react_apps/src/Controller/DplReactAppsController.php
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/KBHBIB-24
danskernesdigitalebibliotek/dpl-design-system#796
danskernesdigitalebibliotek/dpl-react#1587
Description
Added translation strings for Share on Facebook and Copy link buttons
Test
https://varnish.pr-1851.dpl-cms.dplplat01.dpl.reload.dk/