Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation strings for share button labels #1851

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add translation strings for share button labels #1851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab19321
Add translation strings for share button labels
JacobArrow Dec 10, 2024
6213cce
Added translations for aria labels
JacobArrow Dec 12, 2024
55a4dc4
Delete this commit
JacobArrow Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@
"type": "package",
"package": {
"name": "danskernesdigitalebibliotek/dpl-react",
"version": "2024.50.0",
"version": "0.0.0-dev",
JacobArrow marked this conversation as resolved.
Show resolved Hide resolved
"type": "drupal-library",
"dist": {
"url": "https://github.com/danskernesdigitalebibliotek/dpl-react/releases/download/2024.50.0/dist-2024-50-0-971e7c3cbc30ed2ea65d95655b798d67a6aa9d75.zip",
"url": "https://github.com/danskernesdigitalebibliotek/dpl-react/releases/download/branch-KBHBIB-24-material-share-buttons/dist-kbhbib-24-material-share-buttons.zip",
"type": "zip"
},
"require": {
Expand All @@ -56,9 +56,9 @@
"package": {
"name": "danskernesdigitalebibliotek/dpl-design-system",
"type": "drupal-library",
"version": "2024.50.0",
"version": "0.0.0-dev",
"dist": {
"url": "https://github.com/danskernesdigitalebibliotek/dpl-design-system/releases/download/2024.50.0/dist-2024-50-0-fbcaaf96dce9df6ceb2537705578a0f3e882fe08.zip",
"url": "https://github.com/danskernesdigitalebibliotek/dpl-design-system/releases/download/branch-KBHBIB-24-share-buttons/dist-kbhbib-24-share-buttons.zip",
"type": "zip"
}
}
Expand Down Expand Up @@ -90,8 +90,8 @@
"composer/installers": "1.12.0",
"cweagans/composer-patches": "1.7.3",
"danskernesdigitalebibliotek/cms-api": "*",
"danskernesdigitalebibliotek/dpl-design-system": "2024.50.0",
"danskernesdigitalebibliotek/dpl-react": "2024.50.0",
"danskernesdigitalebibliotek/dpl-design-system": "0.0.0-dev",
"danskernesdigitalebibliotek/dpl-react": "0.0.0-dev",
"danskernesdigitalebibliotek/fbs-client": "*",
"dealerdirect/phpcodesniffer-composer-installer": "^1.0.0",
"deoliveiralucas/array-keys-case-transform": "^1.1",
Expand Down
12 changes: 7 additions & 5 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions web/modules/custom/dpl_react_apps/src/Controller/DplReactAppsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,10 @@ public function work(string $wid): array {
'type-text' => $this->t('Type', [], ['context' => 'Work Page']),
'we-have-shopped-text' => $this->t('In stock:', [], ['context' => 'Work Page']),
'you-have-borrowed-text' => $this->t('You have borrowed', [], ['context' => 'Work Page']),
'share-on-facebook-text' => $this->t('Share on Facebook', [], ['context' => 'Work Page']),
JacobArrow marked this conversation as resolved.
Show resolved Hide resolved
'share-on-facebook-aria-label-text' => $this->t('Share this page on Facebook', [], ['context' => 'Work Page']),
'copy-link-text' => $this->t('Copy link', [], ['context' => 'Work Page']),
'copy-link-aria-label-text' => $this->t('Copy this page to clipboard', [], ['context' => 'Work Page']),
// Add external API base urls.
] + self::externalApiBaseUrls();

Expand Down
Loading