Change various icon on loan list page #478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason I do this is to be able to import svg's into stories. If I do not do that I cannot control the svg properties by css. When an svg is used as a src in an image you cannot target the svg propeties.
In that way it is possible to control the fill via css.
spaceo
force-pushed
the
DDFLSBP-59-design-ux-ikon-til-burgermenu-valg-som-listeikon
branch
from
9ada977 to
504d8f1
Compare
This is not optimal, because the DOM is now not aligned with dpl-react a11y wise. I think we need to revise the general setup on this.
Yes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-59
Description
This PR:
Screenshot of the result
Additional comments or questions
Is linked with this.
There is some inconsitency with the accessibility setup/concept between design and react that needs to be looked at.