Change various icon on loan list page #922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaceo
force-pushed
the
DDFLSBP-59-design-ux-ikon-til-burgermenu-valg-som-listeikon
branch
2 times, most recently
from
fb0e4a5 to
71e4426
Compare
spaceo
force-pushed
the
DDFLSBP-59-design-ux-ikon-til-burgermenu-valg-som-listeikon
branch
from
71e4426 to
2f7ad9a
Compare
Adamik10
reviewed
Feb 6, 2024
There was a problem hiding this comment.
From the screenshot it seems like the spacing between the items is not consistent with the design system and Figma. Could we investigate this before merging it in?
Also, I'm not sure which version of the design system we are using here, but just to be sure - it should be this one, right?
| import VariousIcon from "@danskernesdigitalebibliotek/dpl-design-system/build/icons/collection/Various.svg"; | ||
|
|
||
| const IconVarious = () => { | ||
| return <img width={24} height={24} src={VariousIcon} alt="Icon various" />; |
There was a problem hiding this comment.
Weren't we talking about moving away from using tags for icons?
|
The work here is solved in this PR. |
spaceo
deleted the
DDFLSBP-59-design-ux-ikon-til-burgermenu-valg-som-listeikon
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-59
Description
This PR:
Screenshot of the result
Additional comments or questions
Is linked with this.