KBHBIB-24 Share buttons on material #1587
Open
+173
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To leverage the advantages of ´svg´ in the DOM and to change the color on hover, we need to have it as a component. This would not be possible with an `img` tag
JacobArrow
changed the title
| @@ -0,0 +1,23 @@ | |||
| import React from "react"; | |||
There was a problem hiding this comment.
Icons should live in the design system and be used like this:
import ExpandMoreIcon from "@danskernesdigitalebibliotek/dpl-design-system/build/icons/collection/ExpandMore.svg";
There was a problem hiding this comment.
How would you go around rendering an SVG without an img tag this way?
…hen the user has scrolled past the share buttons. This is because we don't want to show the fixed share buttons in the footer
JacobArrow
force-pushed
the
KBHBIB-24-material-share-buttons
branch
from
6ac1175 to
230f95d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/KBHBIB-24
Description
Screenshot of the result
Test
https://varnish.pr-1851.dpl-cms.dplplat01.dpl.reload.dk/