Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support theme (light and dark) colors in the JS code #2331 #2332

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Support theme (light and dark) colors in the JS code #2331 #2332

merged 3 commits into from
Nov 23, 2023

Conversation

roienatan
Copy link
Collaborator

@roienatan roienatan commented Nov 22, 2023 •
edited
Loading

  • PR title equals to the ticket name
  • I added the ticket to the Development section of this PR.

What was changed?

  • Support theme (light and dark) colors in the JS code. See ticket for more details.
  • Direct message modal overlay color to be the default of the modal component.

This PR is related to #2298 and #2267

@netlify Netlify
Copy link

netlify bot commented Nov 22, 2023 •
edited
Loading

✅ Deploy Preview for preview-common ready!

Name Link
🔨 Latest commit 7e1be7e
🔍 Latest deploy log https://app.netlify.com/sites/preview-common/deploys/655e94f78c08e700083fc198
😎 Deploy Preview https://deploy-preview-2332--preview-common.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@roienatan roienatan linked an issue Nov 22, 2023 that may be closed by this pull request
Support theme (light and dark) colors in the JS code #2331
Closed
@roienatan roienatan marked this pull request as ready for review November 22, 2023 23:44
@roienatan roienatan merged commit ef7a10e into dev Nov 23, 2023
5 checks passed
@roienatan roienatan deleted the cw-2331-support-theme-colors-in-js branch November 23, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvm-code pvm-code pvm-code approved these changes

@andreymikhadyuk andreymikhadyuk Awaiting requested review from andreymikhadyuk

@budnik9 budnik9 Awaiting requested review from budnik9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support theme (light and dark) colors in the JS code
2 participants
@roienatan @pvm-code