-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support theme (light and dark) colors in the JS code #2331
Comments
@roienatan
In this login pop-up:
|
@elatif2020 it's changing color because the button becomes disabled while creating the discussion/proposal. Now in dark mode you notice that. For now I removed the background color while loading so it looks good for both light/dark. The button stays the same visually but you still have the not allowed cursor while hovering. Let me know what you think. |
this is good for us |
In rare cases we need to set the colors from the JS (e.g.
LoadingBreadcrumbsItem
andProposalTypeSelect
). For this we need the same colors we have intheme.scss
in our JS code.Related to #2267 and #2298
The text was updated successfully, but these errors were encountered: