Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support theme (light and dark) colors in the JS code #2331

Closed
roienatan opened this issue Nov 22, 2023 · 5 comments · Fixed by #2332
Closed

Support theme (light and dark) colors in the JS code #2331

roienatan opened this issue Nov 22, 2023 · 5 comments · Fixed by #2332
Assignees
Labels
V [production] verified on production enviroment

Comments

@roienatan
Copy link
Collaborator

roienatan commented Nov 22, 2023

In rare cases we need to set the colors from the JS (e.g. LoadingBreadcrumbsItem and ProposalTypeSelect). For this we need the same colors we have in theme.scss in our JS code.

Related to #2267 and #2298

@roienatan roienatan self-assigned this Nov 22, 2023
@roienatan roienatan linked a pull request Nov 22, 2023 that will close this issue
4 tasks
@elatif2020
Copy link
Collaborator

elatif2020 commented Nov 24, 2023

@roienatan
Some additional fixes related to the dark mode:

  • Once I'm in dark mode I think there's a gray mask on the animation in the landing page (web-dev.common.io). Can we remove it?

In this login pop-up:

  • Replace the dark-mode image with this.
  • "terms of use" color should be purple
  • The background of the login options icons.

Image

  • In mobile sidebar, the "Change" should be in the primary color (#C32EA3). Both for current version and v04

Image

@elatif2020
Copy link
Collaborator

After clicking Save the Cancel button is changing color
image

@elatif2020
Copy link
Collaborator

We should have a different color for the mention in my message, should revert to the color we already had (lighter pink)
In the reply it can stay as it is here
Image

@roienatan
Copy link
Collaborator Author

roienatan commented Nov 28, 2023

After clicking Save the Cancel button is changing color image

@elatif2020 it's changing color because the button becomes disabled while creating the discussion/proposal. Now in dark mode you notice that. For now I removed the background color while loading so it looks good for both light/dark. The button stays the same visually but you still have the not allowed cursor while hovering. Let me know what you think.

@roienatan roienatan mentioned this issue Nov 28, 2023
3 tasks
@NoamQA NoamQA added the V [production] verified on production enviroment label Nov 28, 2023
@elatif2020
Copy link
Collaborator

After clicking Save the Cancel button is changing color image

@elatif2020 it's changing color because the button becomes disabled while creating the discussion/proposal. Now in dark mode you notice that. For now I removed the background color while loading so it looks good for both light/dark. The button stays the same visually but you still have the not allowed cursor while hovering. Let me know what you think.

this is good for us
Notice another comment in the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V [production] verified on production enviroment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants