-
Notifications
You must be signed in to change notification settings - Fork 46
Conversation
LGTM, just want to land #141 first to check for breaking changes w.r.t. the version rev. |
PR HealthBreaking changes
|
Package | Change | Current Version | New Version | Needed Version | Looking good? |
---|---|---|---|---|---|
http2 | Breaking | 2.3.0 | 2.3.1-wip | 3.0.0 Got "2.3.1-wip" expected >= "3.0.0" (breaking changes) |
This check can be disabled by tagging the PR with skip-breaking-check
Changelog Entry ✔️
Details
Package | Changed Files |
---|
Changes to files need to be accounted for in their respective changelogs.
Coverage ⚠️
Details
File | Coverage |
---|---|
lib/multiprotocol_server.dart | 💚 89 % |
lib/src/async_utils/async_utils.dart | 💚 100 % |
lib/src/connection.dart | 💚 81 % |
lib/src/connection_preface.dart | 💚 100 % |
lib/src/error_handler.dart | 💚 98 % |
lib/src/flowcontrol/connection_queues.dart | 💚 94 % |
lib/src/flowcontrol/stream_queues.dart | 💔 88 % ⬇️ 0 % |
lib/src/flowcontrol/window_handler.dart | 💚 100 % |
lib/src/frames/frame_reader.dart | 💚 90 % |
lib/src/frames/frame_types.dart | 💔 45 % ⬇️ 6 % |
lib/src/frames/frame_utils.dart | 💚 100 % |
lib/src/frames/frame_writer.dart | 💚 86 % |
lib/src/hpack/hpack.dart | 💚 96 % |
lib/src/ping/ping_handler.dart | 💚 100 % |
lib/src/settings/settings.dart | 💚 94 % |
lib/src/streams/stream_handler.dart | 💚 90 % |
lib/src/sync_errors.dart | 💔 81 % ⬇️ 1 % |
lib/transport.dart | 💔 82 % ⬇️ 2 % |
manual_test/out_of_stream_ids_test.dart | 💔 Not covered |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check
License Headers ✔️
Details
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files |
---|
no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
Files |
---|
test/src/flowcontrol/mocks.mocks.dart |
Package publish validation ✔️
Details
Package | Version | Status |
---|---|---|
package:http2 | 2.3.1-wip | WIP (no publish necessary) |
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.
cc @kevmoo |
It looks like that check is telling us about a parameter type change: https://github.com/dart-lang/http2/actions/runs/7671365367/job/20909551116?pr=140#step:11:189 |
|
Can we ignore these warnings? |
fyi @devmil |
No description provided.