Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Require Dart 3.2, update lints #140

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Require Dart 3.2, update lints #140

merged 3 commits into from
Jan 31, 2024

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Jan 24, 2024

No description provided.

@kevmoo kevmoo requested a review from devoncarew January 24, 2024 22:55
@kevmoo kevmoo enabled auto-merge (squash) January 24, 2024 23:01
@devoncarew devoncarew requested a review from mosuem January 25, 2024 17:13
@mosuem
Copy link
Contributor

mosuem commented Jan 26, 2024

LGTM, just want to land #141 first to check for breaking changes w.r.t. the version rev.

Copy link

PR Health

Breaking changes ⚠️

Details
Package Change Current Version New Version Needed Version Looking good?
http2 Breaking 2.3.0 2.3.1-wip 3.0.0
Got "2.3.1-wip" expected >= "3.0.0" (breaking changes)
⚠️

This check can be disabled by tagging the PR with skip-breaking-check

Changelog Entry ✔️

Details
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️

Details
File Coverage
lib/multiprotocol_server.dart 💚 89 %
lib/src/async_utils/async_utils.dart 💚 100 %
lib/src/connection.dart 💚 81 %
lib/src/connection_preface.dart 💚 100 %
lib/src/error_handler.dart 💚 98 %
lib/src/flowcontrol/connection_queues.dart 💚 94 %
lib/src/flowcontrol/stream_queues.dart 💔 88 % ⬇️ 0 %
lib/src/flowcontrol/window_handler.dart 💚 100 %
lib/src/frames/frame_reader.dart 💚 90 %
lib/src/frames/frame_types.dart 💔 45 % ⬇️ 6 %
lib/src/frames/frame_utils.dart 💚 100 %
lib/src/frames/frame_writer.dart 💚 86 %
lib/src/hpack/hpack.dart 💚 96 %
lib/src/ping/ping_handler.dart 💚 100 %
lib/src/settings/settings.dart 💚 94 %
lib/src/streams/stream_handler.dart 💚 90 %
lib/src/sync_errors.dart 💔 81 % ⬇️ 1 %
lib/transport.dart 💔 82 % ⬇️ 2 %
manual_test/out_of_stream_ids_test.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check

License Headers ✔️

Details
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
test/src/flowcontrol/mocks.mocks.dart

Package publish validation ✔️

Details
Package Version Status
package:http2 2.3.1-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@mosuem
Copy link
Contributor

mosuem commented Jan 29, 2024

PR Health

Breaking changes ⚠️

cc @kevmoo

@devoncarew
Copy link
Contributor

It looks like that check is telling us about a parameter type change:

https://github.com/dart-lang/http2/actions/runs/7671365367/job/20909551116?pr=140#step:11:189

@kevmoo
Copy link
Contributor Author

kevmoo commented Jan 29, 2024

It looks like that check is telling us about a parameter type change:

https://github.com/dart-lang/http2/actions/runs/7671365367/job/20909551116?pr=140#step:11:189

  1. so freakin cool to get this analysis!
  2. changing from no param type (dynamic) to Object? for a param should NOT be a breaking change. (Changing the return type from dynamic to Object? could be breaking.)

@kevmoo
Copy link
Contributor Author

kevmoo commented Jan 29, 2024

Can we ignore these warnings?

@kevmoo kevmoo merged commit aeb506c into master Jan 31, 2024
13 checks passed
@kevmoo kevmoo deleted the update_lints branch January 31, 2024 08:49
@mosuem
Copy link
Contributor

mosuem commented Jan 31, 2024

It looks like that check is telling us about a parameter type change:
https://github.com/dart-lang/http2/actions/runs/7671365367/job/20909551116?pr=140#step:11:189

  1. so freakin cool to get this analysis!
  2. changing from no param type (dynamic) to Object? for a param should NOT be a breaking change. (Changing the return type from dynamic to Object? could be breaking.)

fyi @devmil

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants