backport: bitcoin#15202, #15768, #16432, #17597 (Qt dash core wallet improvements) #5796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knst
added
the
Needs Release Notes
|
before v20.1 is released - let's decide how to call in UI this feature? I will prepare new PR with renaming + release notes when this one will get reviewed/merged. |
|
Trezor and Ledger both call it "discreet mode" in their wallets |
UdjinM6
requested changes
Jan 2, 2024
PastaPastaPasta
approved these changes
Jan 6, 2024
c4b5748 gui: Add Close All Wallets action (João Barbosa) f30960a gui: Add closeAllWallets to WalletController (João Barbosa) Pull request description: This PR adds the action to close all wallets. <img width="405" alt="Screenshot 2020-06-01 at 01 06 12" src="https://user-images.githubusercontent.com/3534524/83365986-25a8b980-a3a4-11ea-9613-24dcd8eaa55c.png"> ACKs for top commit: jonasschnelli: Tested ACK c4b5748 Tree-SHA512: 049ad77ac79949fb55f6bde47b583fbf946f4bfaf3d56d768e85f813d814cff0fe326b700f7b5e383cda4af7b5666e13043a6aaeee3798a69fc94385d88ce809
8d75115 qt: Add privacy feature to Overview page (Hennadii Stepanov) 73d8ef7 qt: Add BitcoinUnits::formatWithPrivacy() function (Hennadii Stepanov) Pull request description: This PR allows to hide/reveal values on the Overviewpage by checking/unchecking Menu->Settings-> Mask Values Closes bitcoin#16407 Privacy mode is OFF (the default behavior):  Privacy mode is ON:  ACKs for top commit: jonatack: Tested ACK 8d75115 jonasschnelli: Tested ACK 8d75115 Tree-SHA512: 42f396d5bf0d343b306fb7e925f86f66b3fc3a257af370a812f4be181b5269298f9b23bd8a3ce25ab61de92908c4018d8c2dc8591d11bc58d79c4eb7206fc6ec
f5a3a5b gui: Add close window shortcut (Miguel Herranz) Pull request description: CMD+W is the standard shortcut in macOS to close a window without exiting the program. This adds support to use the shortcut in both main and debug windows. ACKs for top commit: jonasschnelli: Tested ACK f5a3a5b hebasto: ACK f5a3a5b, tested on Linux Mint 19.3 by manually opening available dialogs and sub-windows, and applying the `Ctrl+W` shortcut. Also tested with "Minimize on close" option enabled / disabled. Tree-SHA512: 39851f6680cf97c334d5759c6f8597cb45685359417493ff8b0566672edbd32303fa15ac4260ec8ab5ea1458a600a329153014f25609e1db9cf399aa851ae2f9
73529f0 qt: Rename slot to updateDisplayUnit() (Hennadii Stepanov) 68288ef qt: Overhaul ReceiveRequestDialog (Hennadii Stepanov) Pull request description: If master (89a1f7a) is compiled without QR support, the "Request payment to..." dialog looks ugly:  With this PR:    Other minor changes: - "URI" abbreviation is not translated now - wallet name is shown if available ACKs for top commit: jonasschnelli: Tested ACK 73529f0 Tree-SHA512: 45f9a41d3c72978d78eb2e8ca98e274b8be5abf5352fd3e1f4f49514ce744994545fb3012e80600ded936ae41c6be4d4825a0c5f7bcb3db671d69e0299f0f65b
PastaPastaPasta
force-pushed
the
bp-v21-qt-1
branch
from
50647c0
to
2cda5f5
Compare
knst
added a commit
to knst/dash
that referenced
this pull request
Feb 20, 2024
follow-up to PR dashpay#5796
5 tasks
PastaPastaPasta
pushed a commit
to knst/dash
that referenced
this pull request
Feb 28, 2024
follow-up to PR dashpay#5796
PastaPastaPasta
added a commit
that referenced
this pull request
Feb 28, 2024
7b3756f fix: rename "Mask values" to "Discreet mode" (Konstantin Akimov) Pull request description: ## Issue being fixed or feature implemented As [noticed by](#5796 (comment)) thephez "Discreet mode" is a good name, Legder and Trezor use that. ## What was done? Renamed qt option "Mask values" to "Discreet mode", update hot-key from Ctrl+Shift+M to Ctrl+Shift+D ## How Has This Been Tested? Build & run qt app ## Breaking Changes N/A, that's just gui text field. ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone Top commit has no ACKs. Tree-SHA512: 515c9c8caab02c78d6edb3859608bd6058dff04e2687567014ad721d2cff255e24bf4dd429dd18b5cac7f6a0f72415a5750fc0590dd6be05d2733ae438f60039
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done?
qt-related backports from bitcoin with new features:
Backports:
How Has This Been Tested?
Run unit/functional tests
To test these functionality just open qt-dash and check it out!
Breaking Changes
N/A
Checklist: