Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: bitcoin#15202, #15768, #16432, #17597 (Qt dash core wallet improvements) #5796

Merged
merged 4 commits into from
Jan 7, 2024

Commits on Jan 7, 2024

  1. Merge bitcoin#15202: gui: Add Close All Wallets action

    c4b5748 gui: Add Close All Wallets action (João Barbosa)
    f30960a gui: Add closeAllWallets to WalletController (João Barbosa)
    
    Pull request description:
    
      This PR adds the action to close all wallets.
    
      <img width="405" alt="Screenshot 2020-06-01 at 01 06 12" src="https://user-images.githubusercontent.com/3534524/83365986-25a8b980-a3a4-11ea-9613-24dcd8eaa55c.png">
    
    ACKs for top commit:
      jonasschnelli:
        Tested ACK c4b5748
    
    Tree-SHA512: 049ad77ac79949fb55f6bde47b583fbf946f4bfaf3d56d768e85f813d814cff0fe326b700f7b5e383cda4af7b5666e13043a6aaeee3798a69fc94385d88ce809
    jonasschnelli authored and PastaPastaPasta committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    00fcc0f View commit details
    Browse the repository at this point in the history
  2. Merge bitcoin#16432: qt: Add privacy to the Overview page

    8d75115 qt: Add privacy feature to Overview page (Hennadii Stepanov)
    73d8ef7 qt: Add BitcoinUnits::formatWithPrivacy() function (Hennadii Stepanov)
    
    Pull request description:
    
      This PR allows to hide/reveal values on the Overviewpage by checking/unchecking Menu->Settings-> Mask Values
    
      Closes bitcoin#16407
    
      Privacy mode is OFF (the default behavior):
      ![Screenshot from 2020-01-02 15-08-28](https://user-images.githubusercontent.com/32963518/71669074-28ab6980-2d74-11ea-8e54-4973aa307192.png)
    
      Privacy mode is ON:
      ![Screenshot from 2020-01-02 15-10-23 cropped](https://user-images.githubusercontent.com/32963518/71669082-2d701d80-2d74-11ea-9df5-d4acc4982dbe.png)
    
    ACKs for top commit:
      jonatack:
        Tested ACK 8d75115
      jonasschnelli:
        Tested ACK 8d75115
    
    Tree-SHA512: 42f396d5bf0d343b306fb7e925f86f66b3fc3a257af370a812f4be181b5269298f9b23bd8a3ce25ab61de92908c4018d8c2dc8591d11bc58d79c4eb7206fc6ec
    jonasschnelli authored and PastaPastaPasta committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    5564cf6 View commit details
    Browse the repository at this point in the history
  3. Merge bitcoin#15768: gui: Add close window shortcut

    f5a3a5b gui: Add close window shortcut (Miguel Herranz)
    
    Pull request description:
    
      CMD+W is the standard shortcut in macOS to close a window without
      exiting the program.
    
      This adds support to use the shortcut in both main and debug windows.
    
    ACKs for top commit:
      jonasschnelli:
        Tested ACK f5a3a5b
      hebasto:
        ACK f5a3a5b, tested on Linux Mint 19.3 by manually opening available dialogs and sub-windows, and applying the `Ctrl+W` shortcut. Also tested with "Minimize on close" option enabled / disabled.
    
    Tree-SHA512: 39851f6680cf97c334d5759c6f8597cb45685359417493ff8b0566672edbd32303fa15ac4260ec8ab5ea1458a600a329153014f25609e1db9cf399aa851ae2f9
    jonasschnelli authored and PastaPastaPasta committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    41dddaf View commit details
    Browse the repository at this point in the history
  4. Merge bitcoin#17597: qt: Fix height of QR-less ReceiveRequestDialog

    73529f0 qt: Rename slot to updateDisplayUnit() (Hennadii Stepanov)
    68288ef qt: Overhaul ReceiveRequestDialog (Hennadii Stepanov)
    
    Pull request description:
    
      If master (89a1f7a) is compiled without QR support, the "Request payment to..." dialog looks ugly:
    
      ![Screenshot from 2019-11-25 19-58-59](https://user-images.githubusercontent.com/32963518/69566647-3d9c1c80-0fc0-11ea-8ff6-183cea9372c5.png)
    
      With this PR:
    
      ![Screenshot from 2019-12-26 00-42-46](https://user-images.githubusercontent.com/32963518/71451226-221c6100-277a-11ea-94ae-c19a5c6256f7.png)
    
      ![Screenshot from 2019-12-26 00-44-34](https://user-images.githubusercontent.com/32963518/71451228-29436f00-277a-11ea-8ac5-1bafe6d73b5c.png)
    
      ![Screenshot from 2019-12-26 00-48-51](https://user-images.githubusercontent.com/32963518/71451230-2e082300-277a-11ea-8c4c-726ca7b776e7.png)
    
      Other minor changes:
      - "URI" abbreviation is not translated now
      - wallet name is shown if available
    
    ACKs for top commit:
      jonasschnelli:
        Tested ACK 73529f0
    
    Tree-SHA512: 45f9a41d3c72978d78eb2e8ca98e274b8be5abf5352fd3e1f4f49514ce744994545fb3012e80600ded936ae41c6be4d4825a0c5f7bcb3db671d69e0299f0f65b
    jonasschnelli authored and PastaPastaPasta committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    2cda5f5 View commit details
    Browse the repository at this point in the history