Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: #959 ditch async_trait for the singlethreade feature #982

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Change: #959 ditch async_trait for the singlethreade feature #982

merged 2 commits into from
Dec 29, 2023

Conversation

wvwwvwwv
Copy link
Contributor

@wvwwvwwv wvwwvwwv commented Dec 28, 2023

Issue #959.

This PR substitutes the existing async_trait macro usage with the async_fn_in_trait language feature which is generally available in Rust 1.75.0 if the singlethreaded feature is turned on.

With this change, in order to use the singlethreaded feature, the minimum supported Rust version is bumped to 1.75.0.

Checklist

  • Updated guide with pertinent info (may not always apply).
  • Squash down commits to one or two logical commits which clearly describe the work you've done.
  • Unittest is a friend:)

This change is Reviewable

@wvwwvwwv
Copy link
Contributor Author

@schreter

Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It looks good to me

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @schreter)

Copy link
Collaborator

@schreter schreter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the change is much smaller than I expected, nice :-).

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wvwwvwwv)

@drmingdrmer drmingdrmer added this pull request to the merge queue Dec 29, 2023
Merged via the queue into databendlabs:main with commit 455422a Dec 29, 2023
25 checks passed
@drmingdrmer drmingdrmer mentioned this pull request Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants