Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to version 0.5 of the specification #19

Merged
merged 20 commits into from
Jan 28, 2025

Conversation

andrewwhitehead
Copy link
Contributor

@andrewwhitehead andrewwhitehead commented Jan 22, 2025

In particular, this adds support for witness verification. The demo script is updated to support prerotation and witnessing. This includes a good amount of refactoring of the resolver to ease in testing and caching, as well as the use of DI proofs in the witness context.

Fixes #14

Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
@andrewwhitehead andrewwhitehead marked this pull request as ready for review January 24, 2025 21:18
@swcurran swcurran requested review from PatStLouis and a team January 24, 2025 21:27
Signed-off-by: Andrew Whitehead <[email protected]>
@ff137 ff137 mentioned this pull request Jan 27, 2025
Copy link
Contributor

@jamshale jamshale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't give a super detailed review, but looked good to me 👍

Copy link

@PatStLouis PatStLouis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried a couple examples, LGTM

@swcurran
Copy link
Contributor

@andrewwhitehead I'll leave it to you to merge at the best time. Not sure how it mixes with the release.

@swcurran
Copy link
Contributor

Andrew gave an official "Okey-Dokey" (which is a very old TV reference...) on this PR. Merging.

@swcurran swcurran merged commit 2ac2b83 into decentralized-identity:main Jan 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for witnessing based on the current specification
4 participants