Implemented a simple SQL based TTL cache #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehenrytsai
requested review from
michaelneale,
mistermoe,
frankhinek,
finn-block and
LiranCohen
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
==========================================
+ Coverage 94.38% 94.71% +0.33%
==========================================
Files 26 27 +1
Lines 2566 2727 +161
Branches 330 350 +20
==========================================
+ Hits 2422 2583 +161
Misses 143 143
Partials 1 1 ☔ View full report in Codecov by Sentry. |
LiranCohen
reviewed
Jul 1, 2024
src/web5-connect/sql-ttl-cache.ts
Outdated
| */ | ||
| public async get(key: string): Promise<object | undefined> { | ||
| // clean up expired entries but no need to await for it to finish | ||
| this.cleanUpExpiredEntries(); |
There was a problem hiding this comment.
sanity: What is the purpose of calling this here since it's running on an interval + the particular record's expiry is checked/deleted below?
There was a problem hiding this comment.
Good point, keeping it simple. Removed.
bnonni
pushed a commit
to FormFree/dwn-server
that referenced
this pull request
Aug 7, 2024
- Implemented a simple SQL based TTL cache. - Introduced `HttpApi.create()` to support async object creation pattern. - Fixed bug in PostgreSQL dialect instantiation. - 100% new code coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpApi.create()to support async object creation pattern.