-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented a simple SQL based TTL cache #140
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,126 @@ | ||
import type { Dialect } from '@tbd54566975/dwn-sql-store'; | ||
import { Kysely } from 'kysely'; | ||
|
||
/** | ||
* The SqlTtlCache is responsible for storing and retrieving cache data with TTL (Time-to-Live). | ||
*/ | ||
export class SqlTtlCache { | ||
private static readonly cacheTableName = 'cacheEntries'; | ||
private static readonly cleanupIntervalInSeconds = 60; | ||
|
||
private db: Kysely<CacheDatabase>; | ||
private cleanupTimer: NodeJS.Timeout; | ||
|
||
private constructor(sqlDialect: Dialect) { | ||
this.db = new Kysely<CacheDatabase>({ dialect: sqlDialect }); | ||
} | ||
|
||
/** | ||
* Creates a new SqlTtlCache instance. | ||
*/ | ||
public static async create(sqlDialect: Dialect): Promise<SqlTtlCache> { | ||
const cacheManager = new SqlTtlCache(sqlDialect); | ||
|
||
await cacheManager.initialize(); | ||
|
||
return cacheManager; | ||
} | ||
|
||
private async initialize(): Promise<void> { | ||
await this.db.schema | ||
.createTable(SqlTtlCache.cacheTableName) | ||
.ifNotExists() | ||
// 512 chars to accommodate potentially large `state` in Web5 Connect flow | ||
.addColumn('key', 'varchar(512)', (column) => column.primaryKey()) | ||
.addColumn('value', 'text', (column) => column.notNull()) | ||
.addColumn('expiry', 'integer', (column) => column.notNull()) | ||
.execute(); | ||
|
||
// Start the cleanup timer | ||
this.startCleanupTimer(); | ||
} | ||
|
||
/** | ||
* Starts a timer to periodically clean up expired cache entries. | ||
*/ | ||
private startCleanupTimer(): void { | ||
this.cleanupTimer = setInterval(async () => { | ||
await this.cleanUpExpiredEntries(); | ||
}, SqlTtlCache.cleanupIntervalInSeconds * 1000); | ||
} | ||
|
||
/** | ||
* Inserts a cache entry. | ||
* @param ttl The time-to-live in seconds. | ||
*/ | ||
public async insert(key: string, value: object, ttl: number): Promise<void> { | ||
const expiry = Date.now() + (ttl * 1000); | ||
|
||
const objectString = JSON.stringify(value); | ||
|
||
await this.db | ||
.insertInto(SqlTtlCache.cacheTableName) | ||
.values({ key, value: objectString, expiry }) | ||
.execute(); | ||
} | ||
|
||
/** | ||
* Retrieves a cache entry if it is not expired and cleans up expired entries. | ||
*/ | ||
public async get(key: string): Promise<object | undefined> { | ||
// clean up expired entries but no need to await for it to finish | ||
this.cleanUpExpiredEntries(); | ||
|
||
const result = await this.db | ||
.selectFrom(SqlTtlCache.cacheTableName) | ||
.select('key') | ||
.select('value') | ||
.select('expiry') | ||
.where('key', '=', key) | ||
.execute(); | ||
|
||
if (result.length === 0) { | ||
return undefined; | ||
} | ||
|
||
const entry = result[0]; | ||
|
||
// if the entry is expired, don't return it and delete it | ||
if (Date.now() >= entry.expiry) { | ||
this.delete(key); // no need to await | ||
return undefined; | ||
} | ||
|
||
return JSON.parse(entry.value); | ||
} | ||
|
||
/** | ||
* Deletes a cache entry. | ||
*/ | ||
public async delete(key: string): Promise<void> { | ||
await this.db | ||
.deleteFrom(SqlTtlCache.cacheTableName) | ||
.where('key', '=', key) | ||
.execute(); | ||
} | ||
|
||
/** | ||
* Periodically clean up expired cache entries. | ||
*/ | ||
public async cleanUpExpiredEntries(): Promise<void> { | ||
await this.db | ||
.deleteFrom(SqlTtlCache.cacheTableName) | ||
.where('expiry', '<', Date.now()) | ||
.execute(); | ||
} | ||
} | ||
|
||
interface CacheEntry { | ||
key: string; | ||
value: string; | ||
expiry: number; | ||
} | ||
|
||
interface CacheDatabase { | ||
cacheEntries: CacheEntry; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sanity: What is the purpose of calling this here since it's running on an interval + the particular record's expiry is checked/deleted below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, keeping it simple. Removed.