deflake web tests #307
Closed
deflake web tests #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamilovtim
requested review from
frankhinek,
csuwildcat and
mistermoe
as code owners
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
TBDocs Report ✅ No errors or warnings @web5/api
Updated @ 2023-11-23T10:00:09.588Z - Commit: |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
==========================================
- Coverage 90.80% 90.80% -0.01%
==========================================
Files 74 74
Lines 14072 14090 +18
Branches 1387 1390 +3
==========================================
+ Hits 12778 12794 +16
- Misses 1269 1270 +1
- Partials 25 26 +1
|
Closed
mistermoe
reviewed
Nov 24, 2023
Comment on lines
+116
to
+118
| env: | ||
| HOMEBREW_NO_AUTO_UPDATE: 1 | ||
| HOMEBREW_NO_INSTALL_CLEANUP: 1 |
There was a problem hiding this comment.
Curious what the motivation is behind adding this!
There was a problem hiding this comment.
This is a well known mac optimization for CI. Without employing various optimizations like this mac CI envs take between 2x-5x amount of time to run CI jobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deflake web tests. bump some timeouts and add retry.