Pex select creds

[nitro-neal]

Overview

Selects credentials that satisfy a given presentation definition.

Description

This PR Implements a new features selectCredentials

• Create Feature
• Create normal unit tests
• Create test vector unit test using local copy of select_credentials_v1.json that is here - https://github.com/TBD54566975/sdk-development/tree/main/web5-test-vectors

This would be used by the user to select which credentials they want to use to satisfy a presentation definition

  /**
   * Selects credentials that satisfy a given presentation definition.
   *
   * @param vcJwts Iterable of VCs in JWT format to select from.
   * @param presentationDefinition The Presentation Definition to match against.
   * @return A list of Verifiable Credentials that satisfy the Presentation Definition.
   */
  public fun selectCredentials(
    vcJwts: Iterable<String>,
    presentationDefinition: PresentationDefinitionV2
  ): List<String> {
    val inputDescriptorToVcMap = mapInputDescriptorsToVCs(vcJwts, presentationDefinition)
    return inputDescriptorToVcMap.flatMap { it.value }.toSet().toList()
  }

• Added unit tests
• Added test vector test

[nitro-neal]

Note this is built upon this pr - #151

this pr - #151 - should be merged in first and this would become much smaller

[codecov]

Codecov Report

Merging #159 (8d45703) into main (466e8d8) will decrease coverage by 0.30%.
Report is 5 commits behind head on main.
The diff coverage is 54.54%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
- Coverage   77.43%   77.13%   -0.30%     
==========================================
  Files          33       33              
  Lines        1928     1929       +1     
  Branches      265      265              
==========================================
- Hits         1493     1488       -5     
+ Misses        301      297       -4     
- Partials      134      144      +10     

Components	Coverage Δ
credentials	72.15% <100.00%> (-8.19%)	⬇️
crypto	38.07% <ø> (ø)
dids	89.59% <ø> (ø)
common	80.44% <ø> (+15.64%)	⬆️

[andresuribe87]

Should there be tests for the error cases ? Some examples I'm thinking about:

1. UnsupportedOperationException is thrown
2. When inputDescriptorToVcMap.size != presentationDefinition.inputDescriptors.size
3. When JsonPathParseException is thrown.

[phoebe-lew]

+1 I think some of the tests above (multiple input descriptors, filtering array vs filtering on value) could be included in the vectors as well

[nitro-neal]

oh yes many more test vectors coming soon (tm),
I was doing this one simple success as a steel thread for the overall web5-kt + web5-js check marks in web5-sdk-development

[phoebe-lew]

Are these tests unrelated to the vector tests?

[nitro-neal]

yup these are just normal unit tests, testing some of the same things

[phoebe-lew]

wdyt about extracting all the vector tests into a separate file so you can tell based on the file name whether it's a vector test?

[nitro-neal]

The thought did cross my mind.
You mean having a new test file called TestVectorTests.kt
and then having credentials test and pex and everything in the credentials package in there?

I could go either way, I do like having the test vector in the same file as the normal unit tests. Less overhead for the devs I think.

Also there would be a lot of imports in the TestVectorTests.kt file, would have to import all stuff from all packages basically

[phoebe-lew]

Yeah did mean something like that, but agree it does feel more natural to have the tests oriented around feature.