Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pex select creds #159
Pex select creds #159
Changes from 21 commits
dfc5507
744dad6
5e1c646
7067c25
ee106e0
2d6eedc
74cd5e1
66e9e6f
6734551
c8380f7
61279a2
e095bc9
c573e36
d8ecb4a
5bc317a
ff56c35
3b74af4
40b69f9
f3f0ac5
c8a30c0
77d0118
20a1aba
8d45703
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these tests unrelated to the vector tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup these are just normal unit tests, testing some of the same things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wdyt about extracting all the vector tests into a separate file so you can tell based on the file name whether it's a vector test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thought did cross my mind.
You mean having a new test file called TestVectorTests.kt
and then having credentials test and pex and everything in the credentials package in there?
I could go either way, I do like having the test vector in the same file as the normal unit tests. Less overhead for the devs I think.
Also there would be a lot of imports in the TestVectorTests.kt file, would have to import all stuff from all packages basically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah did mean something like that, but agree it does feel more natural to have the tests oriented around feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be tests for the error cases ? Some examples I'm thinking about:
UnsupportedOperationException
is throwninputDescriptorToVcMap.size != presentationDefinition.inputDescriptors.size
JsonPathParseException
is thrown.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 I think some of the tests above (multiple input descriptors, filtering array vs filtering on value) could be included in the vectors as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yes many more test vectors coming soon (tm),
I was doing this one simple success as a steel thread for the overall web5-kt + web5-js check marks in web5-sdk-development
Check warning on line 8 in testing/src/main/kotlin/web5/sdk/testing/TestVectors.kt
Codecov / codecov/patch
testing/src/main/kotlin/web5/sdk/testing/TestVectors.kt#L8
Check warning on line 10 in testing/src/main/kotlin/web5/sdk/testing/TestVectors.kt
Codecov / codecov/patch
testing/src/main/kotlin/web5/sdk/testing/TestVectors.kt#L10
Check warning on line 18 in testing/src/main/kotlin/web5/sdk/testing/TestVectors.kt
Codecov / codecov/patch
testing/src/main/kotlin/web5/sdk/testing/TestVectors.kt#L18
Check warning on line 21 in testing/src/main/kotlin/web5/sdk/testing/TestVectors.kt
Codecov / codecov/patch
testing/src/main/kotlin/web5/sdk/testing/TestVectors.kt#L20-L21