-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: Switch docz-plugin-css implementation #418
Conversation
When testing, please double check the |
Thanks for the PR! I'm getting the following error when running
Steps to repro:
The command Looking at your PR I can't figure out why this happened. |
By that criteria (removing Took me a bit, but I've been able to create resolution rules so that removing In any case, that's a much larger change then simply dropping sass support as I've done in this fork. Btw, I've updated the plugin-css fork to update the requirement to docz v1.2, so this also removes all dependencies to docz v0. |
fcefcd0
to
4bbbd93
Compare
The current version of docz-plugin-css uses node-sass v4, which is incompatible to node v16+. Given that pi-ui does not use any sass files, this commit switches the docz-plugin-css dependency to a forked version which drops node-sass and is thus compatible to node v16+.
This should fix intermittent build errors.
Had to add a new commit, adding |
Weird. We've never faced issues with
Yes, but docz v2 isn't that stable either. That's why I'll be writing the docs using another generator: #361 (comment) This PR is important because it allows us to use node v16+ on politeiagui and decredtion right now. I tested locally with the following node versions and works fine:
The only issue is that I'm seeing a lot of warnings I wasn't seeing before. Adding the following plugins to
Can you add these plugins to this PR? |
Tested @tiagoalvesdulce solution and it works. It still displays some warnings, but I was able to run it. Good to mention that warnings are only displayed on first |
I am merging this and will open a new PR to add:
|
The current version of docz-plugin-css uses node-sass v4, which is
incompatible to node v16+.
Given that pi-ui does not use any sass files, this commit switches the
docz-plugin-css dependency to a forked version which drops node-sass and
is thus compatible to node v16+.