Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TableServiceAsyncTest timeout unit test failure #4798

Closed
devinrsmith opened this issue Nov 8, 2023 · 4 comments · Fixed by #4808
Closed

TableServiceAsyncTest timeout unit test failure #4798

devinrsmith opened this issue Nov 8, 2023 · 4 comments · Fixed by #4808
Assignees
@devinrsmith
Labels
bug Something isn't working java-client test triage
Milestone
November 2023

Comments

@devinrsmith
Copy link
Member

It appears that the following test is sometimes failing:

2023-11-08T18:52:13.9139040Z io.deephaven.client.impl.TableServiceAsyncTest > longChainAsyncExportOnlyLast FAILED
2023-11-08T18:52:13.9142554Z     java.util.concurrent.TimeoutException at TableServiceAsyncTest.java:79

It suggests that there is an underlying race (potentially Batch / ETCR or related), or client implementation bug; but it's possible the timeout is too short given CI resources, TBD.
@devinrsmith devinrsmith added bug Something isn't working test java-client labels Nov 8, 2023
@devinrsmith devinrsmith added this to the November 2023 milestone Nov 8, 2023
@devinrsmith devinrsmith self-assigned this Nov 8, 2023
@devinrsmith
Copy link
Member Author

As seen in https://github.com/deephaven/deephaven-core/actions/runs/6802272060/job/18495015941

@devinrsmith devinrsmith mentioned this issue Nov 8, 2023
Closed
devinrsmith added a commit to devinrsmith/deephaven-core that referenced this issue Nov 9, 2023
@devinrsmith
Properly pass along exceptional state in BatchHandler
0e501d3 
This is in support of deephaven#4798. While this _is_ a fix to BatchHandler logic, it isn't the underlying cause of 4798. Next time 4798 is triggered in CI though, we should have more details to go off of.
@devinrsmith devinrsmith mentioned this issue Nov 9, 2023
Merged
@devinrsmith
Copy link
Member Author

I've done 8 CI runs and so far have been unable to reproduce this issue. After #4802 merges, if this issues triggers in CI again we should have much more details to go off of.

@nbauernfeind nbauernfeind mentioned this issue Nov 9, 2023
Merged
devinrsmith added a commit to devinrsmith/deephaven-core that referenced this issue Nov 9, 2023
@devinrsmith
Add better asynchronous impl for TableHandleFuture
a0770b6 
Potential fix for deephaven#4798
devinrsmith added a commit that referenced this issue Nov 9, 2023
@devinrsmith
Add better asynchronous impl for TableHandleFuture (#4802)
c2dd5f3 
This is in support of #4798. This adds some additional logic to BatchHandler to improve logging in exceptional cases. This also fixes some exceptional cases in TableServiceAsyncImpl. I _expected_ this fixes the intermittent test failures.
@devinrsmith
Copy link
Member Author

I think #4802 fixes this - leaving open for a week to see if we here anymore cases.

@nbauernfeind nbauernfeind mentioned this issue Nov 10, 2023
Merged
@devinrsmith devinrsmith changed the title TableServiceAsyncTest longChainAsyncExportOnlyLast unit test failure TableServiceAsyncTest timeout unit test failure Nov 10, 2023
@devinrsmith
Copy link
Member Author

Updated comment to specifically make sure this is about the timeout nature of this issue.

stanbrub pushed a commit that referenced this issue Nov 15, 2023
@devinrsmith @stanbrub
Add better asynchronous impl for TableHandleFuture (#4802)
20abab7 
This is in support of #4798. This adds some additional logic to BatchHandler to improve logging in exceptional cases. This also fixes some exceptional cases in TableServiceAsyncImpl. I _expected_ this fixes the intermittent test failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devinrsmith devinrsmith

Labels
bug Something isn't working java-client test triage
Projects
None yet
Milestone
November 2023
1 participant
@devinrsmith