-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Publish jsapi-types patch release with v0.33 tag #5625
ci: Publish jsapi-types patch release with v0.33 tag #5625
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would call this is a workaround for #5572 as opposed to a "fix"; ideally, we'd plumb appropriate metadata through the job to handle this more generally.
- Should no longer clobber the `latest` tag - Fixes deephaven#5572
2ee8075
to
918aee9
Compare
I'll make a more general workaround and put it on main using the branch name. |
@@ -113,5 +113,5 @@ jobs: | |||
if: ${{ startsWith(github.ref, 'refs/heads/release/v') }} | |||
env: | |||
NODE_AUTH_TOKEN: ${{ secrets.DEEPHAVENBOT_NPM_TOKEN }} | |||
run: npm publish --tag latest web/client-api/types/build/deephaven-jsapi-types-*.tgz | |||
run: npm publish --tag v0.33 web/client-api/types/build/deephaven-jsapi-types-*.tgz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make sure I understand a bit more: a tag here is not the same as npm "version" - it's an additional qualifier that points to a version?
Can a single version have multiple tags?
Looking at https://www.npmjs.com/package/@deephaven/jsapi-types?activeTab=versions, I see the tags latest
, nightly
, and canary
. Are we planning to introduce a new convention for all npm releases, with a tag that is v<major>.<minor>
?
https://docs.npmjs.com/adding-dist-tags-to-packages seems to recommend against this:
We recommend avoiding dist-tags that start with a number or the letter "v".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct; we do the v<major>.<minor>
tagging on the web-client-ui packages: https://www.npmjs.com/package/@deephaven/code-studio?activeTab=versions
But it could be any arbitrary name. Yea npm recommends against it, but not sure what else to name them? We could give them the same name as the Enterprise releases they coincide with (e.g. vplus
), and maybe that would be a better fit (though ironically still wouldn't be recommended, since it starts with v
)?
@devinrsmith actually I'm not sure I can make a more general case with how the release process is right now - it only publishes when the ref matches I don't think there's a way (yet) to distinguish between a |
The more general solution we should discuss relative to #5631 |
latest
tagrc/v0.33.x
workaround for Patch releases of jsapi-types getting dist-taglatest
incorrectly #5572