Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Publish jsapi-types patch release with v0.33 tag #5625

Merged
merged 1 commit into from
Jun 18, 2024
Merged

ci: Publish jsapi-types patch release with v0.33 tag #5625

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/publish-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,5 +113,5 @@ jobs:
if: ${{ startsWith(github.ref, 'refs/heads/release/v') }}
env:
NODE_AUTH_TOKEN: ${{ secrets.DEEPHAVENBOT_NPM_TOKEN }}
run: npm publish --tag latest web/client-api/types/build/deephaven-jsapi-types-*.tgz
run: npm publish --tag v0.33 web/client-api/types/build/deephaven-jsapi-types-*.tgz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make sure I understand a bit more: a tag here is not the same as npm "version" - it's an additional qualifier that points to a version?

Can a single version have multiple tags?

Looking at https://www.npmjs.com/package/@deephaven/jsapi-types?activeTab=versions, I see the tags latest, nightly, and canary. Are we planning to introduce a new convention for all npm releases, with a tag that is v<major>.<minor>?

https://docs.npmjs.com/adding-dist-tags-to-packages seems to recommend against this:

We recommend avoiding dist-tags that start with a number or the letter "v".

Copy link
Member Author

@mofojed mofojed Jun 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct; we do the v<major>.<minor> tagging on the web-client-ui packages: https://www.npmjs.com/package/@deephaven/code-studio?activeTab=versions
But it could be any arbitrary name. Yea npm recommends against it, but not sure what else to name them? We could give them the same name as the Enterprise releases they coincide with (e.g. vplus), and maybe that would be a better fit (though ironically still wouldn't be recommended, since it starts with v)?

continue-on-error: true
Loading