Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: disclosure #1068

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: disclosure #1068

wants to merge 7 commits into from

Conversation

ethanalvizo
Copy link
Contributor

@ethanalvizo ethanalvizo commented Dec 18, 2024 •
edited
Loading

Closes #1037

Web-client-ui PR that exports Accordion and Disclosure is merged. Not sure if it was already a part of the release though

@ethanalvizo ethanalvizo self-assigned this Dec 18, 2024
@ethanalvizo ethanalvizo marked this pull request as ready for review December 26, 2024 21:06
@ethanalvizo ethanalvizo requested a review from mofojed December 31, 2024 20:52
margaretkennedy
margaretkennedy previously approved these changes Jan 3, 2025
View reviewed changes
mofojed
mofojed reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update plugins/ui/src/js/package.json to use the v102 versions of the @deephaven/ packages that include Disclosure to fix the build errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mofojed mofojed mofojed left review comments

@margaretkennedy margaretkennedy margaretkennedy left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@ethanalvizo ethanalvizo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui.disclosure
3 participants
@ethanalvizo @mofojed @margaretkennedy