Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disclosure #1068
base: main
Are you sure you want to change the base?
feat: disclosure #1068
Changes from all commits
fe13317
4fc622b
75f56e6
62e0693
bd2e99e
e110db9
f1050d4
36bd679
ef23d44
389e3ff
84ccde6
ed2a89f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some examples using
disclosure_title
anddisclosure_panel
, showing off disclosures with different levels in thedisclosure_title
, and adisclosure_panel
with some padding.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this code snippet as an example but investigating why they all render with the same style. When inspecting the elements they are rendering as H1, H2, H3,... respectively. Style overwriting seems to be coming from elsewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm it looks like that's actually an issue in React spectrum.
In which case, remove this example, don't bother mentioning
level
, create a follow up ticket that tracks a ticket I filed against React-spectrum: adobe/react-spectrum#7671