Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bind unwrapValue to this.chartUtils #325

Closed
wants to merge 1 commit into from
Closed

Conversation

vbabich
Copy link
Contributor

@vbabich vbabich commented Feb 28, 2024

Plotly-express plugin throws an error in DHE:

User callback ( (e2) => this.handleFigureUpdated(e2, id) ) of type  updated  failed:  JavaScriptException {stackTrace: null, backingJsObject: TypeError: Cannot destructure property 'dh' of 'this' as it is undefined. at unwrapValue

Fix by binding the function to this.chartUtils.

@vbabich vbabich self-assigned this Feb 28, 2024
@vbabich vbabich added this to the February 2024 milestone Feb 28, 2024
@vbabich vbabich enabled auto-merge (squash) February 28, 2024 16:00
@vbabich vbabich requested a review from mattrunyon February 28, 2024 16:00
@mattrunyon
Copy link
Collaborator

This was already bound in https://github.com/deephaven/web-client-ui/pull/1795/files#diff-6390b14205deae6b7442793f3b14cf4a9ed95536d90fd35f07a790c67fdedf5b

Are you running an old version of DHC? The chart package is externalized for the theme provider, so an older version of DHC won't work

That said, we could keep this as it doesn't really hurt anything

@vbabich
Copy link
Contributor Author

vbabich commented Feb 28, 2024

The version I'm using is current for V+, so not too old, but you're right, it doesn't have that fix.
I see @deephaven/chart is an external dependency for plotly-express, I expected utils to be in the bundle.

@mofojed
Copy link
Member

mofojed commented Feb 28, 2024

Should be able to update packages to >v0.64.0 and this should work, no need to make a change here.
deephaven/web-client-ui#1795
https://github.com/deephaven/web-client-ui/releases/tag/v0.64.0

@mattrunyon
Copy link
Collaborator

Just to be clear, the packages need to be updated in DHE and that should work since ChartUtils is part of an externalized package

@vbabich
Copy link
Contributor Author

vbabich commented Feb 29, 2024

Upgrading DHC packages in Enterprise fixed the issue, closing.

@vbabich vbabich closed this Feb 29, 2024
auto-merge was automatically disabled February 29, 2024 21:59

Pull request was closed

@mofojed mofojed deleted the bind-unwrapvalue branch January 13, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants