Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: slider, range slider, checkbox, and content #439

Merged
merged 17 commits into from
May 31, 2024
Merged

Conversation

ethanalvizo
Copy link
Contributor

@ethanalvizo ethanalvizo commented Apr 28, 2024

Closes #297, #298, #299, #440

@ethanalvizo ethanalvizo requested a review from mofojed April 28, 2024 05:09
@ethanalvizo
Copy link
Contributor Author

@mofojed I commented out each prop that I omitted along with the reason they're not included. I thought this would be easier to see which things were left intentionally but if it's preferred to not see them at all I can change it

I also couldn't test the Content component properly. Wasn't sure how to pass in a child component into it.

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix imports, this does not install/run correctly and tests are not running as it is.

@ethanalvizo ethanalvizo requested a review from mofojed May 24, 2024 18:11
@ethanalvizo ethanalvizo self-assigned this May 24, 2024
@ethanalvizo ethanalvizo merged commit 9ba1a04 into main May 31, 2024
14 checks passed
@ethanalvizo ethanalvizo deleted the documentation branch May 31, 2024 01:13
This was referenced Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pydocs for checkbox
2 participants