fix: ui.radio value defaulting #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Investigating failures |
mofojed
requested changes
Sep 18, 2024
| return ( | ||
| <DHRadio | ||
| // eslint-disable-next-line react/jsx-props-no-spreading | ||
| {...props} | ||
| value={value as string} |
There was a problem hiding this comment.
You need to pass children down to DHRadio as well, as you've pulled it out of props. That's why your e2e tests are failing.
Run the script from the ticket and you'll see the issue.
There was a problem hiding this comment.
You shouldn't need as string, value is already a string by this point.
mofojed
requested changes
Sep 18, 2024
| return ( | ||
| <DHRadio | ||
| // eslint-disable-next-line react/jsx-props-no-spreading | ||
| {...props} | ||
| value={value as string} |
There was a problem hiding this comment.
You shouldn't need as string, value is already a string by this point.
mofojed
approved these changes
Sep 18, 2024
|
@AkshatJawne to fix the tests I think you just need to merge in the latest |
|
@mofojed Appears that merging main did not change it, will investigate further |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #765