Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ui.radio value defaulting #818

Merged
merged 6 commits into from
Sep 21, 2024
Merged

fix: ui.radio value defaulting #818

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
540c8cd
fix: ui.radio value defaulting
AkshatJawne Sep 11, 2024
917a1ec
pass children in
AkshatJawne Sep 18, 2024
79ed97a
pass children as prop
AkshatJawne Sep 18, 2024
a21280a
modify according to PR comments
AkshatJawne Sep 18, 2024
8bd8a74
Merge branch 'main' into radio_value_fix
AkshatJawne Sep 19, 2024
88593f3
Merge branch 'main' into radio_value_fix
AkshatJawne Sep 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion plugins/ui/src/js/src/elements/Radio.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,22 +18,29 @@ export function Radio({
onBlur: serializedOnBlur,
onKeyDown: serializedOnKeyDown,
onKeyUp: serializedOnKeyUp,
value: valueProp,
children,
...props
}: SerializedRadioProps): JSX.Element {
const onFocus = useFocusEventCallback(serializedOnFocus);
const onBlur = useFocusEventCallback(serializedOnBlur);
const onKeyDown = useKeyboardEventCallback(serializedOnKeyDown);
const onKeyUp = useKeyboardEventCallback(serializedOnKeyUp);

const value = valueProp ?? (typeof children === 'string' ? children : '');

return (
<DHRadio
// eslint-disable-next-line react/jsx-props-no-spreading
{...props}
value={value}
onFocus={onFocus}
onBlur={onBlur}
onKeyDown={onKeyDown}
onKeyUp={onKeyUp}
/>
>
{children}
</DHRadio>
);
}

Expand Down
Loading